Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce towncrier requirements for docs to fix CI #1052

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

commonism
Copy link
Contributor

Starting with the release of towncrier 24.7 the CI/CD regulary fails as the linter does not work.

sphinxcontrib-towncrier does have an upper boundary for the towncrier version and is incompatible to 24.7.
c.f. sphinx-contrib/sphinxcontrib-towncrier#92

Installing tc 23.11 for docs to avoid getting 24.7.

@bdraco bdraco added the bot:chronographer:skip This PR does not need to include a change note label Aug 14, 2024
@bdraco bdraco changed the title use towncrier 23.11 for docs Enforce towncrier requirements for docs to fix CI Aug 14, 2024
Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @commonism

I started looking into this yesterday but ran out of time. Appreciate the fix

@bdraco bdraco enabled auto-merge (squash) August 14, 2024 11:31
@bdraco
Copy link
Member

bdraco commented Aug 14, 2024

Looks like Codecov is stuck. Will try close reopen

@bdraco bdraco closed this Aug 14, 2024
auto-merge was automatically disabled August 14, 2024 11:32

Pull request was closed

@bdraco bdraco reopened this Aug 14, 2024
@bdraco bdraco merged commit ded4468 into aio-libs:master Aug 14, 2024
76 of 79 checks passed
@commonism commonism deleted the towncrier branch August 14, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants