Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify the build system in pyproject.toml #802

Merged
merged 8 commits into from
Dec 27, 2023

Conversation

Jackenmen
Copy link
Contributor

What do these changes do?

Adds build-backend to pyproject.toml so that there's no warnings from pip when building from source (+ so that modern setuptools backend is used).

Are there changes in behavior for the user?

pip will no longer show warning:

  WARNING: Missing build requirements in pyproject.toml for multidict==6.0.4 from https://files.pythonhosted.org/packages/4a/15/bd620f7a6eb9aa5112c4ef93e7031bcd071e0611763d8e17706ef8ba65e0/multidict-6.0.4.tar.gz.
  WARNING: The project does not specify a build backend, and pip cannot fall back to setuptools without 'wheel'.

Related issue number

None

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> (e.g. 588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the PR
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: Fix issue with non-ascii contents in doctest text files.

@Jackenmen
Copy link
Contributor Author

I'm not sure if a change like this requires a history fragment, let me know :)

@webknjaz
Copy link
Member

I think a misc change fragment would be a good idea. It would be weird to make a release without a changelog entry.

@webknjaz webknjaz enabled auto-merge (squash) December 27, 2022 01:48
@codecov
Copy link

codecov bot commented Dec 27, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (84286ac) 93.65% compared to head (3191e92) 93.65%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #802   +/-   ##
=======================================
  Coverage   93.65%   93.65%           
=======================================
  Files           5        5           
  Lines         504      504           
=======================================
  Hits          472      472           
  Misses         32       32           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Dec 27, 2022
CHANGES/802.misc.rst Outdated Show resolved Hide resolved
CHANGES/802.misc.rst Outdated Show resolved Hide resolved
webknjaz added a commit to Jackenmen/multidict that referenced this pull request Dec 27, 2023
CHANGES/802.misc.rst Outdated Show resolved Hide resolved
@webknjaz webknjaz merged commit 6cb54e2 into aio-libs:master Dec 27, 2023
40 checks passed
@Jackenmen Jackenmen deleted the patch-1 branch December 27, 2023 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants