added support for sqlalchemy default parameters #455 #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So I've changed all the tests to now use pytest, can you update them to match the tests in master. |
Codecov Report
@@ Coverage Diff @@
## master #456 +/- ##
==========================================
+ Coverage 87.20% 87.33% +0.12%
==========================================
Files 9 9
Lines 1180 1192 +12
Branches 172 174 +2
==========================================
+ Hits 1029 1041 +12
Misses 122 122
Partials 29 29
Continue to review full report at Codecov.
|
|
Nice looks good :) |
andr-04
added a commit
to andr-04/aiomysql
that referenced
this pull request
May 18, 2021
* commit '0a8af2355562ea961477738d66b3334332447186': Bump version and tweak setup.py (aio-libs#540) Fill changelog for 0.0.21 release (aio-libs#538) Support python 3.7 and 3.8 in tests and travis CI Update dependencies (aio-libs#485) chore(flake8): fixed flake8 errors (aio-libs#484) added support for sqlalchemy default parameters aio-libs#455 (aio-libs#456) Fix flake Fixed invalid datatime for MySQL 5.7 Rewrote tests to use pytest exclusively Fixed linting Attempted to move db completely to docker Fix Travis attempt 1 Fix aio-libs#454
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Fix #455
Are there changes in behavior for the user?
No changes
Related issue number
#455
Checklist
CHANGESfolder<issue_id>.<type>(e.g.588.bugfix)issue_idchange it to the pr id after creating the PR.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.Fix issue with non-ascii contents in doctest text files.