Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #9939/509fddfd backport][3.12] Fix test_resolve_gitapi_subapps benchmark #9950

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented Nov 17, 2024

This is a backport of PR #9939 as merged into master (509fddf).

Also add checks that url dispatcher benchmarks find expected routes

Also add checks that url dispatcher benchmarks find expected routes

(cherry picked from commit 509fddf)
Copy link

codspeed-hq bot commented Nov 17, 2024

CodSpeed Performance Report

Merging #9950 will degrade performances by 82.52%

Comparing patchback/backports/3.12/509fddfd3c6673bfa5ad11783e8d49e57d5a2fbe/pr-9939 (d8f7e1b) with 3.12 (be6a021)

Summary

❌ 1 (👁 1) regressions
✅ 41 untouched benchmarks

Benchmarks breakdown

Benchmark 3.12 patchback/backports/3.12/509fddfd3c6673bfa5ad11783e8d49e57d5a2fbe/pr-9939 Change
👁 test_resolve_gitapi_subapps[pyloop] 56.3 ms 321.8 ms -82.52%

Copy link

codecov bot commented Nov 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.01%. Comparing base (be6a021) to head (d8f7e1b).
Report is 1 commits behind head on 3.12.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.12    #9950   +/-   ##
=======================================
  Coverage   98.01%   98.01%           
=======================================
  Files         122      122           
  Lines       36710    36771   +61     
  Branches     4424     4426    +2     
=======================================
+ Hits        35981    36042   +61     
  Misses        545      545           
  Partials      184      184           
Flag Coverage Δ
CI-GHA 97.90% <100.00%> (+<0.01%) ⬆️
OS-Linux 97.61% <100.00%> (+<0.01%) ⬆️
OS-Windows 94.49% <100.00%> (+<0.01%) ⬆️
OS-macOS 96.72% <100.00%> (-0.01%) ⬇️
Py-3.10.11 96.57% <100.00%> (+<0.01%) ⬆️
Py-3.10.15 97.16% <100.00%> (+0.04%) ⬆️
Py-3.11.10 97.18% <100.00%> (-0.01%) ⬇️
Py-3.11.9 96.66% <100.00%> (+0.01%) ⬆️
Py-3.12.7 97.68% <100.00%> (+0.01%) ⬆️
Py-3.13.0 97.66% <100.00%> (-0.01%) ⬇️
Py-3.9.13 96.50% <100.00%> (+<0.01%) ⬆️
Py-3.9.20 97.07% <100.00%> (+0.03%) ⬆️
Py-pypy7.3.16 96.64% <100.00%> (+<0.01%) ⬆️
VM-macos 96.72% <100.00%> (-0.01%) ⬇️
VM-ubuntu 97.61% <100.00%> (+<0.01%) ⬆️
VM-windows 94.49% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco enabled auto-merge (squash) November 17, 2024 22:08
@bdraco bdraco merged commit 4c328c0 into 3.12 Nov 17, 2024
35 of 36 checks passed
@bdraco bdraco deleted the patchback/backports/3.12/509fddfd3c6673bfa5ad11783e8d49e57d5a2fbe/pr-9939 branch November 17, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants