Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issues with test_web_urldispatcher when it encounters OS AF_UNIX too long #9728

Merged
merged 2 commits into from
Nov 9, 2024

Conversation

Ok3ks
Copy link
Contributor

@Ok3ks Ok3ks commented Nov 9, 2024

What do these changes do?

This pull request fixes test_web_urldispatcher where there's an OS ERROR: AF_UNIX path too long when this command is ran

pytest -n auto --dist loadscope

Are there changes in behavior for the user?

Is it a substantial burden for the maintainers to support this?

No, I don't think so

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES/ folder
    Fixes issues with test_web_urldispatcher when it encounters OS AF_UNIX too long #9728.bugfix.rst
    Fixed issue with non-ascii contents in doctest text files
    -- by :user:`ok3ks`.

@Ok3ks Ok3ks requested a review from asvetlov as a code owner November 9, 2024 12:18
@bdraco bdraco changed the title Fixes issues with test_web_urldispatcher when it encounters OS AF_UNI… Fixes issues with test_web_urldispatcher when it encounters OS AF_UNIX too long Nov 9, 2024
@bdraco bdraco added bot:chronographer:skip This PR does not need to include a change note backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot labels Nov 9, 2024
Copy link

codspeed-hq bot commented Nov 9, 2024

CodSpeed Performance Report

Merging #9728 will not alter performance

Comparing Ok3ks:fix-path-test_access_special_resource (1130fac) with master (ab9b566)

Summary

✅ 14 untouched benchmarks

@bdraco bdraco enabled auto-merge (squash) November 9, 2024 12:33
Copy link

codecov bot commented Nov 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.66%. Comparing base (500a021) to head (1130fac).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9728      +/-   ##
==========================================
- Coverage   98.67%   98.66%   -0.01%     
==========================================
  Files         117      117              
  Lines       35787    35787              
  Branches     4239     4239              
==========================================
- Hits        35313    35311       -2     
- Misses        319      320       +1     
- Partials      155      156       +1     
Flag Coverage Δ
CI-GHA 98.55% <100.00%> (-0.01%) ⬇️
OS-Linux 98.23% <100.00%> (ø)
OS-Windows 95.99% <0.00%> (-0.01%) ⬇️
OS-macOS 97.30% <100.00%> (ø)
Py-3.10.11 97.16% <100.00%> (ø)
Py-3.10.15 97.71% <100.00%> (ø)
Py-3.11.10 97.77% <100.00%> (ø)
Py-3.11.9 97.22% <100.00%> (-0.01%) ⬇️
Py-3.12.7 98.26% <100.00%> (-0.01%) ⬇️
Py-3.13.0 98.24% <100.00%> (-0.01%) ⬇️
Py-3.9.13 97.07% <100.00%> (-0.01%) ⬇️
Py-3.9.20 97.63% <100.00%> (ø)
Py-pypy7.3.16 97.25% <100.00%> (ø)
VM-macos 97.30% <100.00%> (ø)
VM-ubuntu 98.23% <100.00%> (ø)
VM-windows 95.99% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit 78fcb2c into aio-libs:master Nov 9, 2024
40 of 42 checks passed
Copy link
Contributor

patchback bot commented Nov 9, 2024

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/78fcb2cc35f6251085c3792dc68a299402751935/pr-9728

Backported as #9730

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Nov 9, 2024
…X too long (#9728)

Co-authored-by: Emmanuel Okedele <emmanuel@coefficient.ai>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit 78fcb2c)
Copy link
Contributor

patchback bot commented Nov 9, 2024

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/78fcb2cc35f6251085c3792dc68a299402751935/pr-9728

Backported as #9731

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Nov 9, 2024
…X too long (#9728)

Co-authored-by: Emmanuel Okedele <emmanuel@coefficient.ai>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit 78fcb2c)
bdraco pushed a commit that referenced this pull request Nov 9, 2024
…X too long (#9728)

Co-authored-by: Emmanuel Okedele <emmanuel@coefficient.ai>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit 78fcb2c)
bdraco pushed a commit that referenced this pull request Nov 9, 2024
…atcher when it encounters OS AF_UNIX too long (#9730)
bdraco pushed a commit that referenced this pull request Nov 9, 2024
…atcher when it encounters OS AF_UNIX too long (#9731)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants