Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify keep-alive logic for HTTP/1.0 in ClientRequest #9704

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 7, 2024

Not a functional change. Noticed while looking for another issue that this code could be made more concise

@bdraco bdraco requested a review from asvetlov as a code owner November 7, 2024 17:55
@bdraco bdraco added bot:chronographer:skip This PR does not need to include a change note backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot labels Nov 7, 2024
Copy link

codspeed-hq bot commented Nov 7, 2024

CodSpeed Performance Report

Merging #9704 will not alter performance

Comparing client_reqrep_keepalive_cleanup (c65f861) with master (dd0b6e3)

Summary

✅ 14 untouched benchmarks

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.67%. Comparing base (dd0b6e3) to head (c65f861).
Report is 2 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9704      +/-   ##
==========================================
- Coverage   98.67%   98.67%   -0.01%     
==========================================
  Files         116      116              
  Lines       35733    35731       -2     
  Branches     4238     4237       -1     
==========================================
- Hits        35259    35257       -2     
  Misses        319      319              
  Partials      155      155              
Flag Coverage Δ
CI-GHA 98.55% <100.00%> (-0.01%) ⬇️
OS-Linux 98.23% <100.00%> (-0.01%) ⬇️
OS-Windows 96.12% <100.00%> (-0.01%) ⬇️
OS-macOS 97.43% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 97.28% <100.00%> (-0.01%) ⬇️
Py-3.10.15 97.71% <100.00%> (-0.01%) ⬇️
Py-3.11.10 97.77% <100.00%> (-0.01%) ⬇️
Py-3.11.9 97.35% <100.00%> (+<0.01%) ⬆️
Py-3.12.7 98.26% <100.00%> (-0.01%) ⬇️
Py-3.13.0 98.24% <100.00%> (-0.01%) ⬇️
Py-3.9.13 97.20% <100.00%> (-0.01%) ⬇️
Py-3.9.20 97.63% <100.00%> (-0.01%) ⬇️
Py-pypy7.3.16 97.25% <100.00%> (-0.01%) ⬇️
VM-macos 97.43% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 98.23% <100.00%> (-0.01%) ⬇️
VM-windows 96.12% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit 26d9610 into master Nov 7, 2024
43 of 44 checks passed
@bdraco bdraco deleted the client_reqrep_keepalive_cleanup branch November 7, 2024 19:18
Copy link
Contributor

patchback bot commented Nov 7, 2024

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/26d96107d84d8e5c30ae38b86456634b2e210cf2/pr-9704

Backported as #9706

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Copy link
Contributor

patchback bot commented Nov 7, 2024

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/26d96107d84d8e5c30ae38b86456634b2e210cf2/pr-9704

Backported as #9707

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Nov 7, 2024
bdraco pushed a commit that referenced this pull request Nov 7, 2024
bdraco pushed a commit that referenced this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants