-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change RequestInfo
to be a NamedTuple
to improve performances
#9692
Conversation
CodSpeed Performance ReportMerging #9692 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #9692 +/- ##
==========================================
- Coverage 98.67% 98.67% -0.01%
==========================================
Files 116 116
Lines 35733 35732 -1
Branches 4238 4237 -1
==========================================
- Hits 35259 35258 -1
Misses 319 319
Partials 155 155
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
skipping backport to 3.10 like we did with #9365 (similar change) |
RequestInfo
to be a NamedTuple
to improve performances
Backport to 3.11: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply e85db24 on top of patchback/backports/3.11/e85db24d78c01598395ee0d1c16d19bce54118ba/pr-9692 Backporting merged PR #9692 into master
🤖 @patchback |
) (cherry picked from commit e85db24)
…Tuple` to improve performances (#9708)
closes #9504
2.7x faster creating the
RequestInfo
... 6.16% improvement insend
performanceskipping backport to 3.10 like we did with #9365 (similar change)