Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize WebSocketReader for 2 byte length case #9554

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Optimize WebSocketReader for 2 byte length case #9554

merged 1 commit into from
Oct 28, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 28, 2024

Optimize WebSocketReader for 2 byte length case. The simple 2 byte length unpack can be implemented almost entirely in native code.

The profile showed a lot of time in unpack_from so this should have speed this up a bit more

@bdraco bdraco added the backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot label Oct 28, 2024
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 28, 2024
Copy link

codspeed-hq bot commented Oct 28, 2024

CodSpeed Performance Report

Merging #9554 will improve performances by 14.91%

Comparing length_126 (0b57e5f) with master (10f07ea)

Summary

⚡ 1 improvements
✅ 3 untouched benchmarks

Benchmarks breakdown

Benchmark master length_126 Change
test_read_one_hundred_websocket_text_messages[pyloop] 622.2 µs 541.5 µs +14.91%

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.58%. Comparing base (10f07ea) to head (0b57e5f).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9554   +/-   ##
=======================================
  Coverage   98.58%   98.58%           
=======================================
  Files         113      113           
  Lines       35249    35249           
  Branches     4186     4186           
=======================================
  Hits        34749    34749           
  Misses        338      338           
  Partials      162      162           
Flag Coverage Δ
CI-GHA 98.46% <100.00%> (ø)
OS-Linux 98.13% <100.00%> (ø)
OS-Windows 96.03% <25.00%> (-0.01%) ⬇️
OS-macOS 97.35% <25.00%> (-0.01%) ⬇️
Py-3.10.11 97.21% <25.00%> (-0.01%) ⬇️
Py-3.10.15 97.62% <100.00%> (ø)
Py-3.11.10 97.69% <100.00%> (ø)
Py-3.11.9 97.29% <25.00%> (-0.01%) ⬇️
Py-3.12.7 98.17% <100.00%> (ø)
Py-3.13.0 98.16% <100.00%> (ø)
Py-3.9.13 97.11% <25.00%> (-0.01%) ⬇️
Py-3.9.20 97.52% <100.00%> (ø)
Py-pypy7.3.16 97.17% <100.00%> (ø)
VM-macos 97.35% <25.00%> (-0.01%) ⬇️
VM-ubuntu 98.13% <100.00%> (ø)
VM-windows 96.03% <25.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco marked this pull request as ready for review October 28, 2024 07:30
@bdraco bdraco enabled auto-merge (squash) October 28, 2024 07:30
@bdraco bdraco merged commit ec19bfa into master Oct 28, 2024
39 of 40 checks passed
@bdraco bdraco deleted the length_126 branch October 28, 2024 07:35
Copy link
Contributor

patchback bot commented Oct 28, 2024

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/ec19bfa753ff3cd1869c2e1da4f55ef561897fbb/pr-9554

Backported as #9555

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Oct 28, 2024
bdraco added a commit that referenced this pull request Oct 28, 2024
…e length case (#9555)

Co-authored-by: J. Nick Koston <nick@koston.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant