-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize WebSocketReader for 2 byte length case #9554
Conversation
CodSpeed Performance ReportMerging #9554 will improve performances by 14.91%Comparing Summary
Benchmarks breakdown
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #9554 +/- ##
=======================================
Coverage 98.58% 98.58%
=======================================
Files 113 113
Lines 35249 35249
Branches 4186 4186
=======================================
Hits 34749 34749
Misses 338 338
Partials 162 162
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Backport to 3.11: 💚 backport PR created✅ Backport PR branch: Backported as #9555 🤖 @patchback |
(cherry picked from commit ec19bfa)
…e length case (#9555) Co-authored-by: J. Nick Koston <nick@koston.org>
Optimize WebSocketReader for 2 byte length case. The simple 2 byte length unpack can be implemented almost entirely in native code.
The profile showed a lot of time in
unpack_from
so this should have speed this up a bit more