Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of default auth #9466

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Improve performance of default auth #9466

merged 2 commits into from
Oct 11, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 11, 2024

followup to #8966

Calling .origin() is a bit expensive #7583 (comment)

We should probably cache self._base_url.origin() as self._base_url_origin` so we don't have to build it every time

Probably could guard this with self._default_auth being set as well

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 11, 2024
@bdraco bdraco added the backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot label Oct 11, 2024
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.59%. Comparing base (c1dc794) to head (a0c7402).
Report is 3 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9466   +/-   ##
=======================================
  Coverage   98.59%   98.59%           
=======================================
  Files         105      105           
  Lines       35089    35091    +2     
  Branches     4178     4178           
=======================================
+ Hits        34595    34597    +2     
  Misses        329      329           
  Partials      165      165           
Flag Coverage Δ
CI-GHA 98.47% <100.00%> (+<0.01%) ⬆️
OS-Linux 98.14% <100.00%> (+<0.01%) ⬆️
OS-Windows 96.53% <ø> (ø)
OS-macOS 97.83% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 97.70% <100.00%> (+<0.01%) ⬆️
Py-3.10.15 97.63% <100.00%> (+<0.01%) ⬆️
Py-3.11.10 97.71% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 97.78% <100.00%> (-0.02%) ⬇️
Py-3.12.7 98.19% <100.00%> (+<0.01%) ⬆️
Py-3.13.0 98.17% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 97.60% <100.00%> (+<0.01%) ⬆️
Py-3.9.20 97.53% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 97.16% <100.00%> (+<0.01%) ⬆️
VM-macos 97.83% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 98.14% <100.00%> (+<0.01%) ⬆️
VM-windows 96.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco marked this pull request as ready for review October 11, 2024 14:19
@bdraco bdraco merged commit 03851d1 into master Oct 11, 2024
40 of 41 checks passed
@bdraco bdraco deleted the default_auth_cleanup branch October 11, 2024 14:19
Copy link
Contributor

patchback bot commented Oct 11, 2024

Backport to 3.11: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 03851d1 on top of patchback/backports/3.11/03851d1353f66b4b40593a03c7d5f14b16122944/pr-9466

Backporting merged PR #9466 into master

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/aio-libs/aiohttp.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/3.11/03851d1353f66b4b40593a03c7d5f14b16122944/pr-9466 upstream/3.11
  4. Now, cherry-pick PR Improve performance of default auth #9466 contents into that branch:
    $ git cherry-pick -x 03851d1353f66b4b40593a03c7d5f14b16122944
    If it'll yell at you with something like fatal: Commit 03851d1353f66b4b40593a03c7d5f14b16122944 is a merge but no -m option was given., add -m 1 as follows instead:
    $ git cherry-pick -m1 -x 03851d1353f66b4b40593a03c7d5f14b16122944
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR Improve performance of default auth #9466 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/3.11/03851d1353f66b4b40593a03c7d5f14b16122944/pr-9466
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

bdraco added a commit that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant