Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double unquoting in url dispatcher #9267

Merged
merged 52 commits into from
Sep 23, 2024
Merged
Changes from 3 commits
Commits
Show all changes
52 commits
Select commit Hold shift + click to select a range
d8af609
Fix double unquoting in url dispatcher
bdraco Sep 23, 2024
f0e471e
Revert "Fix double unquoting in url dispatcher"
bdraco Sep 23, 2024
01587b1
fix
bdraco Sep 23, 2024
1426f56
fixes
bdraco Sep 23, 2024
16174eb
fixes
bdraco Sep 23, 2024
a588cab
fix
bdraco Sep 23, 2024
d66ecdf
no way around a breaking change are we need to tell people %2F is no …
bdraco Sep 23, 2024
843581f
Revert "no way around a breaking change are we need to tell people %2…
bdraco Sep 23, 2024
4e1d41e
adjust
bdraco Sep 23, 2024
d89668f
coverage
bdraco Sep 23, 2024
66d1393
fix
bdraco Sep 23, 2024
d125e31
remove unquoting
bdraco Sep 23, 2024
62fea0d
fix
bdraco Sep 23, 2024
fa0f880
fix
bdraco Sep 23, 2024
08b4da7
fix
bdraco Sep 23, 2024
2149f7b
Merge branch 'master' into fix_double_unquoting
bdraco Sep 23, 2024
48d2f73
adjust for a potential yarl revert
bdraco Sep 23, 2024
722fad2
Merge remote-tracking branch 'upstream/fix_double_unquoting' into fix…
bdraco Sep 23, 2024
e7551ff
fix url_for for plain
bdraco Sep 23, 2024
34cfa5a
downgrade yarl to get a CI run
bdraco Sep 23, 2024
7a4c527
Revert "Switch to using `yarl.URL.absolute` over `yarl.URL.is_absolut…
bdraco Sep 23, 2024
0237dbe
Revert "Remove unused backwards compatibility code for old yarl versi…
bdraco Sep 23, 2024
1b9db46
one more place
bdraco Sep 23, 2024
c842bd4
Revert "one more place"
bdraco Sep 23, 2024
7b41d4e
Revert "Revert "Remove unused backwards compatibility code for old ya…
bdraco Sep 23, 2024
195e3f2
Revert "Revert "Switch to using `yarl.URL.absolute` over `yarl.URL.is…
bdraco Sep 23, 2024
f477850
Revert "downgrade yarl to get a CI run"
bdraco Sep 23, 2024
4cb1e82
unquoted
bdraco Sep 23, 2024
3cc1d29
Update tests/test_urldispatch.py
bdraco Sep 23, 2024
2142d7f
coverage
bdraco Sep 23, 2024
bc974f0
Merge remote-tracking branch 'upstream/fix_double_unquoting' into fix…
bdraco Sep 23, 2024
efd49d1
type
bdraco Sep 23, 2024
60c6e95
having the raw_path will not help since we cannot use it for the regex
bdraco Sep 23, 2024
ee3502f
use path_safe
bdraco Sep 23, 2024
ddc538e
Update aiohttp/web_urldispatcher.py
bdraco Sep 23, 2024
d987829
its always %2F
bdraco Sep 23, 2024
0e5b5a9
changelog
bdraco Sep 23, 2024
d7988fb
Update tests/test_urldispatch.py
bdraco Sep 23, 2024
3fefa9b
Update tests/test_web_urldispatcher.py
bdraco Sep 23, 2024
31c182a
Update tests/test_web_urldispatcher.py
bdraco Sep 23, 2024
28cd7f9
Update tests/test_urldispatch.py
Dreamsorcerer Sep 23, 2024
544a476
Increase minimum yarl version to 1.12.0
bdraco Sep 23, 2024
5b9225f
changelog
bdraco Sep 23, 2024
ff1f2f5
Update CHANGES/9268.breaking.rst
bdraco Sep 23, 2024
170bae0
fix test
bdraco Sep 23, 2024
ac79e5a
test will fail
bdraco Sep 23, 2024
fc78f54
Merge branch 'min_yarl_1120' into fix_double_unquoting
bdraco Sep 23, 2024
74175fc
Merge remote-tracking branch 'upstream/fix_double_unquoting' into fix…
bdraco Sep 23, 2024
ea33da4
changelog
bdraco Sep 23, 2024
0f7d802
changelog
bdraco Sep 23, 2024
7f9eebd
remove xfail
bdraco Sep 23, 2024
2694229
fix issue id
bdraco Sep 23, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion aiohttp/web_urldispatcher.py
Original file line number Diff line number Diff line change
Expand Up @@ -1257,7 +1257,7 @@ def _quote_path(value: str) -> str:


def _unquote_path(value: str) -> str:
return URL.build(path=value, encoded=True).path.replace("%2F", "/")
Dreamsorcerer marked this conversation as resolved.
Show resolved Hide resolved
return value.replace("%2F", "/")
bdraco marked this conversation as resolved.
Show resolved Hide resolved


def _requote_path(value: str) -> str:
Expand Down
Loading