Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move reversing slice of middleware apps into the cache #9170

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Sep 18, 2024

What do these changes do?

In post merge self re-review of #9158, I noticed I should have moved the reversing into the cache so it doesn't have to happen every time.

Are there changes in behavior for the user?

no

Is it a substantial burden for the maintainers to support this?

no

In post merge self re-review of #9158, I noticed I
should have moved the reversing into the cache
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Sep 18, 2024
@bdraco bdraco added backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot and removed bot:chronographer:provided There is a change note present in this PR labels Sep 18, 2024
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Sep 18, 2024
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.31%. Comparing base (bf022b3) to head (909fd8b).
Report is 5 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9170   +/-   ##
=======================================
  Coverage   98.31%   98.31%           
=======================================
  Files         107      107           
  Lines       34483    34483           
  Branches     4093     4093           
=======================================
  Hits        33901    33901           
  Misses        411      411           
  Partials      171      171           
Flag Coverage Δ
CI-GHA 98.20% <100.00%> (ø)
OS-Linux 97.87% <100.00%> (ø)
OS-Windows 96.28% <100.00%> (ø)
OS-macOS 97.54% <100.00%> (ø)
Py-3.10.11 97.64% <100.00%> (ø)
Py-3.10.14 97.49% <100.00%> (-0.09%) ⬇️
Py-3.10.15 97.39% <100.00%> (-0.14%) ⬇️
Py-3.11.9 97.81% <100.00%> (ø)
Py-3.12.5 ?
Py-3.12.6 97.92% <100.00%> (+0.27%) ⬆️
Py-3.9.13 97.53% <100.00%> (ø)
Py-3.9.19 97.38% <100.00%> (-0.09%) ⬇️
Py-3.9.20 97.29% <100.00%> (-0.19%) ⬇️
Py-pypy7.3.16 97.08% <100.00%> (-0.01%) ⬇️
VM-macos 97.54% <100.00%> (ø)
VM-ubuntu 97.87% <100.00%> (ø)
VM-windows 96.28% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco marked this pull request as ready for review September 18, 2024 05:52
@bdraco bdraco merged commit eacf2e0 into master Sep 18, 2024
39 of 40 checks passed
@bdraco bdraco deleted the reverse_list_order_in_lru branch September 18, 2024 13:18
Copy link
Contributor

patchback bot commented Sep 18, 2024

Backport to 3.10: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply eacf2e0 on top of patchback/backports/3.10/eacf2e0dff4077318d6c112edb1c62bbcd6daf82/pr-9170

Backporting merged PR #9170 into master

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/aio-libs/aiohttp.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/3.10/eacf2e0dff4077318d6c112edb1c62bbcd6daf82/pr-9170 upstream/3.10
  4. Now, cherry-pick PR Move reversing slice of middleware apps into the cache #9170 contents into that branch:
    $ git cherry-pick -x eacf2e0dff4077318d6c112edb1c62bbcd6daf82
    If it'll yell at you with something like fatal: Commit eacf2e0dff4077318d6c112edb1c62bbcd6daf82 is a merge but no -m option was given., add -m 1 as follows instead:
    $ git cherry-pick -m1 -x eacf2e0dff4077318d6c112edb1c62bbcd6daf82
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR Move reversing slice of middleware apps into the cache #9170 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/3.10/eacf2e0dff4077318d6c112edb1c62bbcd6daf82/pr-9170
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Copy link
Contributor

patchback bot commented Sep 18, 2024

Backport to 3.11: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply eacf2e0 on top of patchback/backports/3.11/eacf2e0dff4077318d6c112edb1c62bbcd6daf82/pr-9170

Backporting merged PR #9170 into master

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/aio-libs/aiohttp.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/3.11/eacf2e0dff4077318d6c112edb1c62bbcd6daf82/pr-9170 upstream/3.11
  4. Now, cherry-pick PR Move reversing slice of middleware apps into the cache #9170 contents into that branch:
    $ git cherry-pick -x eacf2e0dff4077318d6c112edb1c62bbcd6daf82
    If it'll yell at you with something like fatal: Commit eacf2e0dff4077318d6c112edb1c62bbcd6daf82 is a merge but no -m option was given., add -m 1 as follows instead:
    $ git cherry-pick -m1 -x eacf2e0dff4077318d6c112edb1c62bbcd6daf82
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR Move reversing slice of middleware apps into the cache #9170 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/3.11/eacf2e0dff4077318d6c112edb1c62bbcd6daf82/pr-9170
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

bdraco added a commit that referenced this pull request Sep 18, 2024
bdraco added a commit that referenced this pull request Sep 18, 2024
bdraco added a commit that referenced this pull request Sep 18, 2024
bdraco added a commit that referenced this pull request Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants