-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move reversing slice of middleware apps into the cache #9170
Conversation
In post merge self re-review of #9158, I noticed I should have moved the reversing into the cache
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #9170 +/- ##
=======================================
Coverage 98.31% 98.31%
=======================================
Files 107 107
Lines 34483 34483
Branches 4093 4093
=======================================
Hits 33901 33901
Misses 411 411
Partials 171 171
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Backport to 3.10: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply eacf2e0 on top of patchback/backports/3.10/eacf2e0dff4077318d6c112edb1c62bbcd6daf82/pr-9170 Backporting merged PR #9170 into master
🤖 @patchback |
Backport to 3.11: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply eacf2e0 on top of patchback/backports/3.11/eacf2e0dff4077318d6c112edb1c62bbcd6daf82/pr-9170 Backporting merged PR #9170 into master
🤖 @patchback |
(cherry picked from commit eacf2e0)
(cherry picked from commit eacf2e0)
What do these changes do?
In post merge self re-review of #9158, I noticed I should have moved the reversing into the cache so it doesn't have to happen every time.
Are there changes in behavior for the user?
no
Is it a substantial burden for the maintainers to support this?
no