Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #7043/bee613d0 backport][3.11] Add clarification about GracefulExit when using handle_signals=True #9123

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented Sep 11, 2024

This is a backport of PR #7043 as merged into master (bee613d).

What do these changes do?

Clarify that GracefulExit needs to be handled manually when using handle_signals=True in AppRunner and ServerRunner.

Are there changes in behavior for the user?

N/A

Related issue number

Fixes #4414

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.77%. Comparing base (398eef2) to head (e213b5f).
Report is 4 commits behind head on 3.11.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.11    #9123   +/-   ##
=======================================
  Coverage   97.77%   97.77%           
=======================================
  Files         108      108           
  Lines       34578    34578           
  Branches     4108     4108           
=======================================
  Hits        33808    33808           
  Misses        575      575           
  Partials      195      195           
Flag Coverage Δ
CI-GHA 97.67% <ø> (ø)
OS-Linux 97.35% <ø> (-0.01%) ⬇️
OS-Windows 94.92% <ø> (ø)
OS-macOS 97.04% <ø> (-0.01%) ⬇️
Py-3.10.11 97.13% <ø> (ø)
Py-3.10.14 97.06% <ø> (ø)
Py-3.11.9 97.29% <ø> (ø)
Py-3.12.5 97.39% <ø> (ø)
Py-3.9.13 97.03% <ø> (+<0.01%) ⬆️
Py-3.9.19 96.97% <ø> (ø)
Py-pypy7.3.16 96.57% <ø> (ø)
VM-macos 97.04% <ø> (-0.01%) ⬇️
VM-ubuntu 97.35% <ø> (-0.01%) ⬇️
VM-windows 94.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dreamsorcerer Dreamsorcerer merged commit 8596dc2 into 3.11 Sep 11, 2024
31 of 32 checks passed
@Dreamsorcerer Dreamsorcerer deleted the patchback/backports/3.11/bee613d090cab3b7c00a83604668181961b562ff/pr-7043 branch September 11, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants