Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove extra MultiDictProxy wrapper from BaseRequest.query #9098

Merged
merged 3 commits into from
Sep 10, 2024
Merged

Remove extra MultiDictProxy wrapper from BaseRequest.query #9098

merged 3 commits into from
Sep 10, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Sep 10, 2024 •
edited
Loading

What do these changes do?

Remove extra MultiDictProxy wrapper from BaseRequest.query
query is already a MultiDictProxy even as far back as yarl 1.0.0 https://github.com/aio-libs/yarl/blob/829f6568916f9f3219a940720bee65103ca591c2/yarl/__init__.py#L472

Are there changes in behavior for the user?

no

Is it a substantial burden for the maintainers to support this?

no

@bdraco bdraco added backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot labels Sep 10, 2024
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Sep 10, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.30%. Comparing base (ffcf9dc) to head (338a7cd).
Report is 5 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #9098   +/-   ##
=======================================
  Coverage   98.30%   98.30%           
=======================================
  Files         107      107           
  Lines       34403    34427   +24     
  Branches     4081     4085    +4     
=======================================
+ Hits        33819    33844   +25     
+ Misses        412      411    -1     
  Partials      172      172
Flag Coverage Δ
CI-GHA 98.20% <100.00%> (+<0.01%) ⬆️
OS-Linux 97.86% <100.00%> (+<0.01%) ⬆️
OS-Windows 96.27% <100.00%> (+<0.01%) ⬆️
OS-macOS 97.54% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 97.63% <100.00%> (+<0.01%) ⬆️
Py-3.10.14 97.57% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 97.80% <100.00%> (+<0.01%) ⬆️
Py-3.12.5 97.92% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 97.52% <100.00%> (+<0.01%) ⬆️
Py-3.9.19 97.46% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 97.08% <100.00%> (+<0.01%) ⬆️
VM-macos 97.54% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 97.86% <100.00%> (+<0.01%) ⬆️
VM-windows 96.27% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco marked this pull request as ready for review September 10, 2024 03:55
@bdraco
Revert "timeline"
338a7cd 
This reverts commit 78c7ad7.
@bdraco bdraco added bot:chronographer:skip This PR does not need to include a change note and removed bot:chronographer:provided There is a change note present in this PR labels Sep 10, 2024
@bdraco bdraco enabled auto-merge (squash) September 10, 2024 14:53
@bdraco bdraco merged commit 94685fb into master Sep 10, 2024
34 of 35 checks passed
@bdraco bdraco deleted the useless_wrapper branch September 10, 2024 17:54
@patchback Patchback
Copy link
Contributor

patchback bot commented Sep 10, 2024 •
edited
Loading

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/94685fb672296629c93b41e1528268c2a667c806/pr-9098

Backported as #9112

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Sep 10, 2024
@bdraco @patchback
Remove extra MultiDictProxy wrapper from BaseRequest.query (#…
be5d139 
…9098)

(cherry picked from commit 94685fb)
@patchback patchback bot mentioned this pull request Sep 10, 2024
Merged
@patchback Patchback
Copy link
Contributor

patchback bot commented Sep 10, 2024 •
edited
Loading

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/94685fb672296629c93b41e1528268c2a667c806/pr-9098

Backported as #9113

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Sep 10, 2024
@bdraco @patchback
Remove extra MultiDictProxy wrapper from BaseRequest.query (#…
8b26153 
…9098)

(cherry picked from commit 94685fb)
@patchback patchback bot mentioned this pull request Sep 10, 2024
Merged
Dreamsorcerer pushed a commit that referenced this pull request Sep 12, 2024
@patchback @bdraco
[PR #9098/94685fb6 backport][3.11] Remove extra MultiDictProxy wr…
5ad9ed2 
…apper from ``BaseRequest.query`` (#9113)

**This is a backport of PR #9098 as merged into master
(94685fb).**

Co-authored-by: J. Nick Koston <nick@koston.org>
Dreamsorcerer pushed a commit that referenced this pull request Sep 12, 2024
@patchback @bdraco
[PR #9098/94685fb6 backport][3.10] Remove extra MultiDictProxy wr…
501f503 
…apper from ``BaseRequest.query`` (#9112)

**This is a backport of PR #9098 as merged into master
(94685fb).**

Co-authored-by: J. Nick Koston <nick@koston.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dreamsorcerer Dreamsorcerer Dreamsorcerer left review comments

@webknjaz webknjaz Awaiting requested review from webknjaz

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees
No one assigned
Labels
backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bdraco @Dreamsorcerer