Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proposal for #423 adding test utilities to aiohttp. #902

Merged
merged 1 commit into from
Jun 3, 2016
Merged

proposal for #423 adding test utilities to aiohttp. #902

merged 1 commit into from
Jun 3, 2016

Conversation

toumorokoshi
Copy link
Contributor

@toumorokoshi toumorokoshi commented Jun 2, 2016 •
edited
Loading

What do these changes do?

Adds builtin test utilities to aiohttp, for unittest and a common framework for other libraries.

How to test your changes?

unit tests have been added. see test_test_utils.py

Related issue number

#423

Checklist

  • Code is written and well (hope so!)
  • Tests for the changes are provided
  • Documentation reflects the changes

@coveralls
Copy link

coveralls commented Jun 2, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-0.2%) to 98.04% when pulling 0b82875 on toumorokoshi:master into c059e0b on KeepSafe:master.

@coveralls
Copy link

coveralls commented Jun 2, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-0.01%) to 98.202% when pulling 035fbde on toumorokoshi:master into c059e0b on KeepSafe:master.

@asvetlov asvetlov merged commit 31f0ef9 into aio-libs:master Jun 3, 2016
@asvetlov
Copy link
Member

asvetlov commented Jun 3, 2016

Perfect! Thanks!

@asvetlov asvetlov mentioned this pull request Jun 3, 2016
Closed
@asvetlov asvetlov mentioned this pull request Sep 11, 2016
Closed
@toumorokoshi toumorokoshi mentioned this pull request Aug 9, 2017
Merged
3 tasks
@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
outdated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@toumorokoshi @coveralls @asvetlov