Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix router matching pre-encoded URLs (#8898) #8960

Conversation

Dreamsorcerer
Copy link
Member

Co-authored-by: J. Nick Koston nick@koston.org
(cherry picked from commit 6be9452)

Co-authored-by: J. Nick Koston <nick@koston.org>
(cherry picked from commit 6be9452)
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Aug 31, 2024
Copy link

codecov bot commented Aug 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.73%. Comparing base (7477503) to head (2a40ba4).
Report is 1 commits behind head on 3.11.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.11    #8960   +/-   ##
=======================================
  Coverage   97.73%   97.73%           
=======================================
  Files         108      108           
  Lines       34319    34314    -5     
  Branches     4073     4073           
=======================================
- Hits        33542    33538    -4     
+ Misses        581      580    -1     
  Partials      196      196           
Flag Coverage Δ
CI-GHA 97.63% <100.00%> (+<0.01%) ⬆️
OS-Linux 97.31% <100.00%> (-0.01%) ⬇️
OS-Windows 94.87% <100.00%> (+<0.01%) ⬆️
OS-macOS 97.00% <100.00%> (-0.01%) ⬇️
Py-3.10.11 97.09% <100.00%> (+<0.01%) ⬆️
Py-3.10.14 97.02% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 97.25% <100.00%> (+<0.01%) ⬆️
Py-3.12.5 97.35% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 96.99% <100.00%> (-0.01%) ⬇️
Py-3.9.19 96.93% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 96.52% <100.00%> (+<0.01%) ⬆️
VM-macos 97.00% <100.00%> (-0.01%) ⬇️
VM-ubuntu 97.31% <100.00%> (-0.01%) ⬇️
VM-windows 94.87% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dreamsorcerer Dreamsorcerer merged commit 9ac6853 into 3.11 Aug 31, 2024
30 of 31 checks passed
@Dreamsorcerer Dreamsorcerer deleted the patchback/backports/3.11/6be94520ea46fe1829e6c9d986e7fc9f7db50cad/pr-8898 branch August 31, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant