Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test coverage of TextIOWrapper #8936

Merged
merged 5 commits into from
Aug 30, 2024
Merged

Test coverage of TextIOWrapper #8936

merged 5 commits into from
Aug 30, 2024

Conversation

Dreamsorcerer
Copy link
Member

No description provided.

@Dreamsorcerer Dreamsorcerer added bot:chronographer:skip This PR does not need to include a change note backport-3.10 backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot labels Aug 29, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.27%. Comparing base (7681235) to head (f40a450).
Report is 1075 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #8936   +/-   ##
=======================================
  Coverage   98.26%   98.27%           
=======================================
  Files         107      107           
  Lines       34217    34226    +9     
  Branches     4058     4058           
=======================================
+ Hits        33625    33637   +12     
+ Misses        418      416    -2     
+ Partials      174      173    -1
Flag Coverage Δ
CI-GHA 98.17% <100.00%> (+<0.01%) ⬆️
OS-Linux 97.83% <100.00%> (+<0.01%) ⬆️
OS-Windows 96.24% <100.00%> (+0.01%) ⬆️
OS-macOS 97.51% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 97.60% <100.00%> (+<0.01%) ⬆️
Py-3.10.14 97.53% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 97.77% <100.00%> (+<0.01%) ⬆️
Py-3.12.5 97.88% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 97.49% <100.00%> (+<0.01%) ⬆️
Py-3.9.19 97.43% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 97.04% <100.00%> (+<0.01%) ⬆️
VM-macos 97.51% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 97.83% <100.00%> (+<0.01%) ⬆️
VM-windows 96.24% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dreamsorcerer
Copy link
Member Author

Why does this fail on Windows...?

Dreamsorcerer
Dreamsorcerer commented Aug 30, 2024
View reviewed changes
tests/test_formdata.py Outdated Show resolved Hide resolved
@Dreamsorcerer Dreamsorcerer changed the title Test coverage of TexIOWrapper Test coverage of TextIOWrapper Aug 30, 2024
@Dreamsorcerer Dreamsorcerer merged commit 76a00d1 into master Aug 30, 2024
34 of 35 checks passed
@Dreamsorcerer Dreamsorcerer deleted the test-cov branch August 30, 2024 12:44
@patchback Patchback
Copy link
Contributor

patchback bot commented Aug 30, 2024 •
edited
Loading

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/76a00d1ed405c87cf33c66f91d410c95e57c0312/pr-8936

Backported as #8944

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Aug 30, 2024
@Dreamsorcerer @patchback
Test coverage of TextIOWrapper (#8936)
a47b622 
(cherry picked from commit 76a00d1)
@patchback patchback bot mentioned this pull request Aug 30, 2024
Merged
@patchback Patchback
Copy link
Contributor

patchback bot commented Aug 30, 2024 •
edited
Loading

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/76a00d1ed405c87cf33c66f91d410c95e57c0312/pr-8936

Backported as #8945

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Aug 30, 2024
@Dreamsorcerer @patchback
Test coverage of TextIOWrapper (#8936)
66b7830 
(cherry picked from commit 76a00d1)
@patchback patchback bot mentioned this pull request Aug 30, 2024
Merged
Dreamsorcerer added a commit that referenced this pull request Aug 30, 2024
@patchback @Dreamsorcerer
[PR #8936/76a00d1e backport][3.11] Test coverage of TextIOWrapper (#8945
aa90362 
)

**This is a backport of PR #8936 as merged into master
(76a00d1).**

---------

Co-authored-by: Sam Bull <git@sambull.org>
Dreamsorcerer added a commit that referenced this pull request Aug 30, 2024
@patchback @Dreamsorcerer
[PR #8936/76a00d1e backport][3.10] Test coverage of TextIOWrapper (#8944
181c042 
)

**This is a backport of PR #8936 as merged into master
(76a00d1).**

---------

Co-authored-by: Sam Bull <git@sambull.org>
@booniepepper booniepepper mentioned this pull request Sep 3, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees
No one assigned
Labels
backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Dreamsorcerer