Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup for #8495 #8541

Merged
merged 13 commits into from
Jul 29, 2024
Merged

Cleanup for #8495 #8541

merged 13 commits into from
Jul 29, 2024

Conversation

Dreamsorcerer
Copy link
Member

No description provided.

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jul 27, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 27, 2024
View reviewed changes
tests/test_run_app.py Dismissed Show dismissed Hide dismissed
tests/test_run_app.py Dismissed Show dismissed Hide dismissed
@codecov Codecov
Copy link

codecov bot commented Jul 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.68%. Comparing base (4f834b6) to head (80141ca).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #8541   +/-   ##
=======================================
  Coverage   97.68%   97.68%           
=======================================
  Files         107      107           
  Lines       33350    33402   +52     
  Branches     3918     3923    +5     
=======================================
+ Hits        32578    32630   +52     
  Misses        559      559           
  Partials      213      213
Flag Coverage Δ
CI-GHA 97.59% <100.00%> (+<0.01%) ⬆️
OS-Linux 97.25% <100.00%> (+<0.01%) ⬆️
OS-Windows 95.64% <100.00%> (+<0.01%) ⬆️
OS-macOS 96.92% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 97.05% <96.55%> (-0.01%) ⬇️
Py-3.10.14 97.00% <96.55%> (-0.01%) ⬇️
Py-3.11.9 97.23% <96.55%> (-0.01%) ⬇️
Py-3.12.4 97.36% <96.55%> (-0.01%) ⬇️
Py-3.8.10 95.40% <98.27%> (+<0.01%) ⬆️
Py-3.8.18 96.89% <98.27%> (+<0.01%) ⬆️
Py-3.9.13 97.04% <100.00%> (-0.01%) ⬇️
Py-3.9.19 97.00% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 96.57% <100.00%> (+<0.01%) ⬆️
VM-macos 96.92% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 97.25% <100.00%> (+<0.01%) ⬆️
VM-windows 95.64% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dreamsorcerer Dreamsorcerer added the backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot label Jul 28, 2024
@bdraco
Copy link
Member

bdraco commented Jul 28, 2024

Looks good. There are some minor lint issues remaining.

@Dreamsorcerer Dreamsorcerer marked this pull request as ready for review July 29, 2024 10:51
@Dreamsorcerer Dreamsorcerer merged commit a561fa9 into master Jul 29, 2024
37 of 38 checks passed
@Dreamsorcerer Dreamsorcerer deleted the finish-shutdown-pr branch July 29, 2024 10:52
@patchback Patchback
Copy link
Contributor

patchback bot commented Jul 29, 2024 •
edited
Loading

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/a561fa990427383358b19dc1eabc968e03a95413/pr-8541

Backported as #8544

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jul 29, 2024
@Dreamsorcerer @patchback
Cleanup for #8495 (#8541)
7559c75 
(cherry picked from commit a561fa9)
@patchback patchback bot mentioned this pull request Jul 29, 2024
Merged
Dreamsorcerer added a commit that referenced this pull request Jul 29, 2024
@patchback @Dreamsorcerer
[PR #8541/a561fa99 backport][3.10] Cleanup for #8495 (#8544)
ed8de3a 
**This is a backport of PR #8541 as merged into master
(a561fa9).**

---------

Co-authored-by: Sam Bull <git@sambull.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdraco bdraco bdraco approved these changes

@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees
No one assigned
Labels
backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dreamsorcerer @bdraco