Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL encode problem:quote url first in order to encode unreserve characters #809

Closed
wants to merge 2 commits into from

Conversation

wanggp3
Copy link

@wanggp3 wanggp3 commented Mar 1, 2016

What these changes does?

Just change two line in client_reqrep.py, the 74 and 86 line to quote url

How to test your changes?

Before my change, it's unable to get the

http://www.gilt.com/search?q.query=Sam Edelman&q.rows=48&q.category=womens-coats&q.start=-48

because the url contains blank. After it can. the simple testfile can be found in my issue808

Related issue number

issue808

Checklist

  • Code is written and well
  • Tests for the changes are provided
    Tests for the changes are provided
  • Documentation reflects the changes

@kxepal
Copy link
Member

kxepal commented Mar 1, 2016

I think escaping whole URI is a bit overkill:

>>> from aiohttp.helpers import requote_uri
>>> requote_uri('http://пример.рф')
'http://%D0%BF%D1%80%D0%B8%D0%BC%D0%B5%D1%80.%D1%80%D1%84'

In other words international domain names will suffer from this.

@asvetlov
Copy link
Member

Fixed by #1217

@asvetlov asvetlov closed this Sep 30, 2016
@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants