Fixed 7616: EmptyStreamReader.iter_chunks() never ends #7644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ter_chunks() never ends
psf-chronographer
bot
added
the
bot:chronographer:provided
|
Looks like failing test |
Codecov Report
@@ Coverage Diff @@
## master #7644 +/- ##
=======================================
Coverage 97.36% 97.36%
=======================================
Files 106 106
Lines 31541 31550 +9
Branches 3593 3595 +2
=======================================
+ Hits 30709 30718 +9
Misses 630 630
Partials 202 202
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
I stripped the comments because I think the code is fairly clear, and the tests ensure someone won't mess it up in future. |
Backport to 3.9: 💚 backport PR created✅ Backport PR branch: Backported as #7645 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Oct 3, 2023
## What do these changes do? Fixes an issue reported in [7616](#7616) - An iteration of the chunks of an EmptyStreamReader with iter_chunks() never ends. ## Are there changes in behavior for the user? - `EmptyStreamReader` `iter_chunks()` does not get stuck - First call of `EmptyStreamReader` `readchunk()` now returns `(b"", False)`. All the subsequent calls return `(b"", True)`. Before this PR it was always `(b"", True)`. ## Related issue number [7616](#7616) (cherry picked from commit 6639f7d)
Merged
5 tasks
Dreamsorcerer
pushed a commit
that referenced
this pull request
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Fixes an issue reported in 7616 - An iteration of the chunks of an EmptyStreamReader with iter_chunks() never ends.
Are there changes in behavior for the user?
EmptyStreamReaderiter_chunks()does not get stuckEmptyStreamReaderreadchunk()now returns(b"", False). All the subsequent calls return(b"", True). Before this PR it was always(b"", True).Related issue number
7616
Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.