Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "http-parser -> llhttp" #6143

Merged
merged 1 commit into from
Oct 27, 2021
Merged

Revert "http-parser -> llhttp" #6143

merged 1 commit into from
Oct 27, 2021

Conversation

asvetlov
Copy link
Member

Reverts #5364

@asvetlov asvetlov added the bot:chronographer:skip This PR does not need to include a change note label Oct 27, 2021
@asvetlov asvetlov enabled auto-merge (squash) October 27, 2021 14:11
@asvetlov asvetlov mentioned this pull request Oct 27, 2021
Merged
5 tasks
@codecov
Copy link

codecov bot commented Oct 27, 2021 •
edited
Loading

Codecov Report

Merging #6143 (c11a96a) into master (58f86f5) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6143      +/-   ##
==========================================
- Coverage   93.32%   93.31%   -0.02%     
==========================================
  Files         102      102              
  Lines       30140    30140              
  Branches     2696     2696              
==========================================
- Hits        28129    28125       -4     
- Misses       1837     1841       +4     
  Partials      174      174
Flag Coverage Δ
unit 93.24% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiohttp/web_app.py 97.33% <100.00%> (ø)
aiohttp/web_middlewares.py 100.00% <100.00%> (ø)
aiohttp/web_urldispatcher.py 97.54% <100.00%> (ø)
tests/conftest.py 66.66% <0.00%> (-1.71%) ⬇️
tests/test_run_app.py 86.05% <0.00%> (-0.60%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fc598c...c11a96a. Read the comment docs.

@asvetlov asvetlov merged commit 7cea67a into master Oct 27, 2021
@asvetlov asvetlov deleted the revert-5364-llhttp branch October 27, 2021 14:24
asvetlov added a commit that referenced this pull request Oct 27, 2021
@asvetlov
Revert "Revert "http-parser -> llhttp (#5364)" (#6143)"
759b5ca 
This reverts commit 7cea67a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz is a code owner

Assignees
No one assigned
Labels
bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@asvetlov