Feat: Add compression strategy #5948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psf-chronographer
bot
added
the
bot:chronographer:provided
Codecov Report
@@ Coverage Diff @@
## master #5948 +/- ##
=======================================
Coverage 96.75% 96.75%
=======================================
Files 44 44
Lines 9852 9852
Branches 1591 1591
=======================================
Hits 9532 9532
Misses 182 182
Partials 138 138
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
asvetlov
approved these changes
Oct 24, 2021
|
Thanks! |
Backport to 3.8: 💚 backport PR created✅ Backport PR branch: Backported as #6127 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Oct 24, 2021
Co-authored-by: Anes Abismail <anesabismail@gmail.com> (cherry picked from commit bcb74cb)
5 tasks
asvetlov
pushed a commit
that referenced
this pull request
Oct 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Add compression strategy parameter to enable_compression method.
Are there changes in behavior for the user?
The added parameter allows users to have control over the compression.
Related issue number
#5909
Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.