Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pip upgrade on windows machines #5648 #5649

Merged
merged 1 commit into from
Apr 26, 2021
Merged

Fix pip upgrade on windows machines #5648 #5649

merged 1 commit into from
Apr 26, 2021

Conversation

greshilov
Copy link
Contributor

@greshilov greshilov commented Apr 26, 2021 •
edited
Loading

What do these changes do?

Possible fix for #5648.

Are there changes in behavior for the user?

No.

Related issue number

#5648

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Apr 26, 2021
@codecov
Copy link

codecov bot commented Apr 26, 2021 •
edited
Loading

Codecov Report

Merging #5649 (e86b59a) into master (1a4126a) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5649      +/-   ##
==========================================
- Coverage   97.21%   97.17%   -0.04%     
==========================================
  Files          41       41              
  Lines        8863     8865       +2     
  Branches     1425     1425              
==========================================
- Hits         8616     8615       -1     
- Misses        130      133       +3     
  Partials      117      117
Flag Coverage Δ
unit 97.06% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiohttp/worker.py 94.91% <0.00%> (-2.55%) ⬇️
aiohttp/web_fileresponse.py 98.62% <0.00%> (ø)
aiohttp/pytest_plugin.py 97.48% <0.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a4126a...e86b59a. Read the comment docs.

webknjaz
webknjaz reviewed Apr 26, 2021
View reviewed changes
Makefile
@@ -49,7 +49,7 @@ endif
.SECONDARY: $(call to-hash,$(ALLS))

.update-pip:
@pip install -U 'pip'
@python -m pip install --upgrade pip
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this any different?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see what you mean. The log is here: https://github.com/aio-libs/aiohttp/pull/5647/checks?check_run_id=2435935600#step:6:14

@webknjaz webknjaz merged commit 4c663a2 into aio-libs:master Apr 26, 2021
@patchback
Copy link
Contributor

patchback bot commented Apr 26, 2021 •
edited
Loading

Backport to 3.8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.8/4c663a2c887d8a18e5f4220288e3324569e34b8b/pr-5649

Backported as #5650

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Apr 26, 2021
@greshilov
Fix pip upgrade on windows machines #5648 (#5649)
d991285 
(cherry picked from commit 4c663a2)
@patchback patchback bot mentioned this pull request Apr 26, 2021
Merged
5 tasks
webknjaz pushed a commit that referenced this pull request Apr 26, 2021
@patchback @greshilov
[PR #5649/4c663a2c backport][3.8] Fix pip upgrade on windows machines #…
7914393 
…5648 (#5650)

(cherry picked from commit 4c663a2)

Co-authored-by: Slava <slovaricheg@gmail.com>
@greshilov greshilov mentioned this pull request Apr 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webknjaz webknjaz webknjaz left review comments

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees
No one assigned
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@greshilov @webknjaz