Hotfix #5408

[greshilov]

What do these changes do?

Hotfix for auto-merged #5408

Are there changes in behavior for the user?

Related issue number

Checklist

• I think the code is well written
• Unit tests for the changes exist
• Documentation reflects the changes
• If you provide code modification, please add yourself to CONTRIBUTORS.txt
  • The format is <Name> <Surname>.
  • Please keep alphabetical order, the file is sorted by names.
• Add a new news fragment into the CHANGES folder
  • name it <issue_id>.<type> for example (588.bugfix)
  • if you don't have an issue_id change it to the pr id after creating the pr
  • ensure type is one of the following:
    • .feature: Signifying a new feature.
    • .bugfix: Signifying a bug fix.
    • .doc: Signifying a documentation improvement.
    • .removal: Signifying a deprecation or removal of public API.
    • .misc: A ticket has been closed, but it is not of interest to users.
  • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

[codecov]

Codecov Report

Merging #5416 (7b5de8a) into master (01bb774) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5416   +/-   ##
=======================================
  Coverage   97.17%   97.17%           
=======================================
  Files          41       41           
  Lines        8742     8742           
  Branches     1402     1402           
=======================================
  Hits         8495     8495           
  Misses        129      129           
  Partials      118      118           

Flag	Coverage Δ
unit	97.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01bb774...7b5de8a. Read the comment docs.

[greshilov]

Also, it's not clear how well dependabot works with files included via -r. It may be necessary to apply pip-tools there as well.

@webknjaz
How exactly should I implement this?

[greshilov]

I think pip-compile hook in .pre-commit-config.yml is also a good addition for checking that all dependencies are in sync.

[webknjaz]

How exactly should I implement this?

Just have pairs of in+txt file for each

[webknjaz]

I think pip-compile hook in .pre-commit-config.yml is also a good addition for checking that all dependencies are in sync.

Won't it always attempt to update the pins and fail the check along with unrelated changes?

[greshilov]

I think pip-compile hook in .pre-commit-config.yml is also a good addition for checking that all dependencies are in sync.

Won't it always attempt to update the pins and fail the check along with unrelated changes?

Fair enough.