Enforce strict mypy checks #5370

derlih · 2020-12-24T17:54:54Z

What do these changes do?

Fix typing for mypy strict mode

Are there changes in behavior for the user?

no

Related issue number

#3927

Checklist

I think the code is well written
Unit tests for the changes exist
Documentation reflects the changes
If you provide code modification, please add yourself to CONTRIBUTORS.txt
- The format is <Name> <Surname>.
- Please keep alphabetical order, the file is sorted by names.
Add a new news fragment into the CHANGES folder
- name it <issue_id>.<type> for example (588.bugfix)
- if you don't have an issue_id change it to the pr id after creating the pr
- ensure type is one of the following:
  - .feature: Signifying a new feature.
  - .bugfix: Signifying a bug fix.
  - .doc: Signifying a documentation improvement.
  - .removal: Signifying a deprecation or removal of public API.
  - .misc: A ticket has been closed, but it is not of interest to users.
- Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

derlih · 2020-12-24T18:16:22Z

Locally I don't have this mypy errors in tests. :-(
@asvetlov @webknjaz Do we really need to run mypy on tests folder?

webknjaz · 2020-12-25T11:51:31Z

Yes. The tests are code too.

webknjaz · 2020-12-25T14:24:13Z

Also, can't you granularly apply the strictness to certain packages via mypy.ini?

derlih · 2020-12-26T18:12:46Z

Yes. The tests are code too.

Well. It depends :-)
The purpose of the tests is to test correctness and functionality, but not the typing (since we using python and not c++).
I never applied type hints to tests for example. But for the code itself I usually put type hints.

codecov · 2020-12-26T18:27:25Z

Codecov Report

Merging #5370 (eaee5aa) into master (3014db4) will decrease coverage by 0.00%.
The diff coverage is 96.83%.

@@            Coverage Diff             @@
##           master    #5370      +/-   ##
==========================================
- Coverage   97.17%   97.17%   -0.01%     
==========================================
  Files          41       41              
  Lines        8742     8768      +26     
  Branches     1402     1404       +2     
==========================================
+ Hits         8495     8520      +25     
- Misses        129      130       +1     
  Partials      118      118

Flag	Coverage Δ
unit	`97.05% <96.83%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
aiohttp/web_protocol.py	`86.41% <ø> (ø)`
aiohttp/resolver.py	`93.18% <50.00%> (ø)`
aiohttp/web_runner.py	`97.74% <66.66%> (ø)`
aiohttp/http_parser.py	`97.23% <91.30%> (+0.08%)`	⬆️
aiohttp/helpers.py	`96.68% <93.75%> (-0.21%)`	⬇️
aiohttp/client_exceptions.py	`98.33% <100.00%> (ø)`
aiohttp/client_reqrep.py	`97.53% <100.00%> (+<0.01%)`	⬆️
aiohttp/connector.py	`96.51% <100.00%> (ø)`
aiohttp/cookiejar.py	`98.78% <100.00%> (ø)`
aiohttp/formdata.py	`98.92% <100.00%> (ø)`
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3014db4...eaee5aa. Read the comment docs.

webknjaz · 2020-12-26T20:01:14Z

Type checking can reveal problems in test just like in any other code.

Makefile

webknjaz · 2021-01-15T12:39:32Z

CHANGES/3927.misc

@@ -0,0 +1 @@
+Use mypy --strict


Suggested change

Use mypy --strict

Use ``mypy --strict``

webknjaz · 2021-01-15T12:43:24Z

aiohttp/web_protocol.py

+    {},  # type: ignore
+    {},  # type: ignore


Could you specify which errors are getting ignored? I saw syntax like # type: ignore:SomeError somewhere but I can't recall if it's documented.

Done. I was not aware of this syntax.

webknjaz · 2021-01-18T23:10:39Z

aiohttp/client_reqrep.py

-                    self.body = (self.body,)  # type: ignore
+                    body = (self.body,)
+                else:
+                    body = self.body


This looks like a logic change unrelated to typing

I've restored the logic

webknjaz · 2021-01-20T12:17:02Z

aiohttp/web_ws.py

@@ -299,7 +309,7 @@ def ws_protocol(self) -> Optional[str]:
        return self._ws_protocol

    @property
-    def compress(self) -> bool:
+    def compress(self) -> int:


Why did you change this instead of converting the return value right below?

webknjaz · 2021-01-20T12:18:22Z

tests/test_client_session.py

-    session = ClientSession(timeout=500)
-    assert session.timeout == 500
+    timeout = ClientTimeout(total=500)
+    session = ClientSession(timeout=timeout)


Why can't session timeout accept int?

This reverts commit 68905c1.

This reverts commit 7a8b193.

This reverts commit 52db00f.

This reverts commit ac6c7f4.

This reverts commit d559a39.

derlih · 2021-01-20T16:54:00Z

@webknjaz I removed all changes and specified only mypy error codes in type: ignore[code]

aio-libs-github-bot · 2021-01-21T13:43:30Z

💔 Backport was not successful

The PR was attempted backported to the following branches:

❌ 3.8: Commit could not be cherrypicked due to conflicts

webknjaz · 2021-01-21T13:44:27Z

@derlih mind backporting this to 3.8? https://docs.aiohttp.org/en/stable/contributing.html#backporting

derlih · 2021-01-21T13:48:13Z

@derlih mind backporting this to 3.8? https://docs.aiohttp.org/en/stable/contributing.html#backporting

I will try to

@derlih

This change covers the entire codebase with strict typings and makes the ignores granular. PR aio-libs#5370 by @derlih. (cherry picked from commit 742a8b6) Co-authored-by: Dmitry Erlikh <derlih@gmail.com>

@derlih

This change covers the entire codebase with strict typings and makes the ignores granular. PR #5370 by @derlih. (cherry picked from commit 742a8b6) Co-authored-by: Dmitry Erlikh <derlih@gmail.com>

@derlih

This change covers the entire codebase with strict typings and makes the ignores granular. PR aio-libs#5370 by @derlih

@derlih

This change covers the entire codebase with strict typings and makes the ignores granular. PR aio-libs#5370 by @derlih

@derlih

This change covers the entire codebase with strict typings and makes the ignores granular. PR aio-libs#5370 by @derlih

derlih requested review from asvetlov and webknjaz as code owners December 24, 2020 17:54

psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Dec 24, 2020

webknjaz reviewed Dec 26, 2020

View reviewed changes

Makefile Outdated Show resolved Hide resolved

derlih force-pushed the mypy-strict branch 2 times, most recently from 9408e31 to 9a77c42 Compare December 27, 2020 12:49

derlih requested a review from webknjaz January 14, 2021 16:26

webknjaz reviewed Jan 15, 2021

View reviewed changes

derlih added 15 commits January 18, 2021 17:47

Run mypy --strict

fd8317e

fix resolver

0047ccd

fix helpers

9d8f691

fix payload

6dff8bf

fix http_websocket

ef0ecaf

fix http_parser.py

7f57094

fix worker.py

1b3e577

fix web_urldispatcher.py

4772e9f

typing.Awaitable (deprecated since 3.9) -> collections.abc.Awaitable

04d63b2

fix web_response.py

6727aef

fix web_app.py

312a85f

Fix multipart.py

4097515

Fix web_request.py + additions to http_parser.py

8358217

Add some typing to helpers.py

ba2b92b

fix connector.py

4828a5e

derlih force-pushed the mypy-strict branch from 4450357 to 52db00f Compare January 18, 2021 16:47

fix WebSocketResponse._compress typing

7a8b193

derlih requested a review from webknjaz January 18, 2021 17:26

webknjaz reviewed Jan 18, 2021

View reviewed changes

restore client_reqrep body logic

68905c1

derlih requested a review from webknjaz January 20, 2021 09:52

webknjaz reviewed Jan 20, 2021

View reviewed changes

derlih added 6 commits January 20, 2021 17:00

Revert "restore client_reqrep body logic"

9bcca14

This reverts commit 68905c1.

Revert "fix WebSocketResponse._compress typing"

34a46c9

This reverts commit 7a8b193.

Revert "fix web_ws.py"

246990d

This reverts commit 52db00f.

Revert "fix test_client_session.py"

1cfac3c

This reverts commit ac6c7f4.

Revert "mypy specific ignores"

e465642

This reverts commit d559a39.

Specify mypy errors for ignore only

eaee5aa

derlih requested a review from webknjaz January 20, 2021 16:54

webknjaz added the backport-3.8 label Jan 21, 2021

webknjaz approved these changes Jan 21, 2021

View reviewed changes

webknjaz changed the title ~~mypy --strict~~ Enforce strict mypy checks Jan 21, 2021

webknjaz merged commit 742a8b6 into aio-libs:master Jan 21, 2021

derlih mentioned this pull request Jan 21, 2021

[3.8] Enforce strict mypy checks #5425

Merged

5 tasks

derlih deleted the mypy-strict branch January 21, 2021 16:24

alandtse pushed a commit to alandtse/aiohttp that referenced this pull request Feb 14, 2021

Enforce strict mypy checks

ed851cc

This change covers the entire codebase with strict typings and makes the ignores granular. PR aio-libs#5370 by @derlih

commonism pushed a commit to commonism/aiohttp that referenced this pull request Apr 27, 2021

Enforce strict mypy checks

104d717

This change covers the entire codebase with strict typings and makes the ignores granular. PR aio-libs#5370 by @derlih

commonism pushed a commit to commonism/aiohttp that referenced this pull request Apr 27, 2021

Enforce strict mypy checks

470853d

This change covers the entire codebase with strict typings and makes the ignores granular. PR aio-libs#5370 by @derlih

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enforce strict mypy checks #5370

Enforce strict mypy checks #5370

derlih commented Dec 24, 2020

derlih commented Dec 24, 2020

webknjaz commented Dec 25, 2020

webknjaz commented Dec 25, 2020 •

edited

Loading

derlih commented Dec 26, 2020

codecov bot commented Dec 26, 2020 •

edited

Loading

webknjaz commented Dec 26, 2020

webknjaz Jan 15, 2021

derlih Jan 17, 2021

webknjaz Jan 15, 2021

derlih Jan 18, 2021

webknjaz Jan 18, 2021

derlih Jan 19, 2021

webknjaz Jan 20, 2021

webknjaz Jan 20, 2021

derlih commented Jan 20, 2021

aio-libs-github-bot bot commented Jan 21, 2021

webknjaz commented Jan 21, 2021

derlih commented Jan 21, 2021 •

edited by webknjaz

Loading

Enforce strict mypy checks #5370

Enforce strict mypy checks #5370

Conversation

derlih commented Dec 24, 2020

What do these changes do?

Are there changes in behavior for the user?

Related issue number

Checklist

derlih commented Dec 24, 2020

webknjaz commented Dec 25, 2020

webknjaz commented Dec 25, 2020 • edited Loading

derlih commented Dec 26, 2020

codecov bot commented Dec 26, 2020 • edited Loading

Codecov Report

webknjaz commented Dec 26, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

derlih commented Jan 20, 2021

aio-libs-github-bot bot commented Jan 21, 2021

💔 Backport was not successful

webknjaz commented Jan 21, 2021

derlih commented Jan 21, 2021 • edited by webknjaz Loading

webknjaz commented Dec 25, 2020 •

edited

Loading

codecov bot commented Dec 26, 2020 •

edited

Loading

derlih commented Jan 21, 2021 •

edited by webknjaz

Loading