-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix race condition on connect when tracing is active (#5259) #5285
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5285 +/- ##
==========================================
- Coverage 97.54% 97.53% -0.02%
==========================================
Files 43 43
Lines 8794 8789 -5
Branches 1415 1410 -5
==========================================
- Hits 8578 8572 -6
- Misses 101 103 +2
+ Partials 115 114 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Thanks! |
💚 Backport successfulThe PR was backported to the following branches:
|
Acquire the connection before running traces, to prevent race condition.
This change will ensure that the limit and limit_per_host functionality in BaseConnector works when traces are configured.
NOTE: Unit tests are TBD as this is an async race condition which is extremely difficult to unit test. Suggestions are welcome.
Related issue number
Fixes #5259
Checklist
CONTRIBUTORS.txt
CHANGES
folder<issue_id>.<type>
for example (588.bugfix)issue_id
change it to the pr id after creating the pr.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.