Form data processed #4351
Merged
Form data processed #4351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psf-chronographer
bot
added
the
bot:chronographer:provided
Codecov Report
@@ Coverage Diff @@
## master #4351 +/- ##
==========================================
- Coverage 97.49% 97.48% -0.02%
==========================================
Files 43 43
Lines 8857 8861 +4
Branches 1388 1389 +1
==========================================
+ Hits 8635 8638 +3
- Misses 97 98 +1
Partials 125 125
Continue to review full report at Codecov.
|
|
I decided to raise a ClientPayloadError if the FormData instance has already been processed. Is this the best Exception or is there something more fitting? I also think this code could break some people's code as even in some of the other tests code broke. Should I add documentation somewhere? |
asvetlov
requested changes
Nov 17, 2019
|
Change-note is enough, I don't think we should document it additionally. |
asvetlov
pushed a commit
that referenced
this pull request
Nov 18, 2019
(cherry picked from commit 0273535) Co-authored-by: Adam Bannister <adam.p.bannister@gmail.com>
asvetlov
added a commit
that referenced
this pull request
Nov 18, 2019
asvetlov
pushed a commit
that referenced
this pull request
Oct 16, 2020
3 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
A FormData instance keeps track whether it has been processed already. If the instance is sent for a second time then it raises a ClientPayloadError.
Are there changes in behavior for the user?
Will raise an exception if they try to resend a FormData instance.
Related issue number
#4345
Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.