Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connector caching #415

Merged
merged 9 commits into from
Jun 20, 2015
Merged

Connector caching #415

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b7ee19e
Rename DNS caching methods
asvetlov Jun 12, 2015
353778c
Work on cache_dns renaming
asvetlov Jun 14, 2015
3939eb8
More tests
asvetlov Jun 20, 2015
a61d05f
More tests
asvetlov Jun 20, 2015
c4a7015
Update doc for reflecting new DNS cache names
asvetlov Jun 20, 2015
1b26860
Add warning for resolve parameter in TCPConnector ctor
asvetlov Jun 20, 2015
b6ee6d8
Fix typo
asvetlov Jun 20, 2015
15d7c5b
cache_dns -> dns_cache
asvetlov Jun 20, 2015
d5f2ac8
Rename to use_dns_cache
asvetlov Jun 20, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix typo
  • Loading branch information
@asvetlov
asvetlov committed Jun 20, 2015
commit b6ee6d8a8f4be110fb0c020dc97f4c56418d43f4
2 changes: 1 addition & 1 deletion aiohttp/connector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,7 +429,7 @@ def __init__(self, *, verify_ssl=True, fingerprint=None,

if cache_dns is not _marker and resolve is not _marker:
if cache_dns != resolve:
raise ValueError("cashe_dns must agree with resolve")
raise ValueError("cache_dns must agree with resolve")
_cache_dns = cache_dns
elif cache_dns is not _marker:
_cache_dns = cache_dns
Expand Down