Fixing keep-alive #406
Merged
Fixing keep-alive #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please fix pep8 error from Travis build |
|
I feel you PR is perfect but we need stronger test for keepalives. Scenario is:
|
|
Good point. |
|
Thanks a lot! |
|
NP, my pleasure. |
|
I think this patch is wrong. Without it I see sockets correclty reused; with it I see single transports/sockets being used by two separate coroutines |
mpaolini
pushed a commit
to elastic-coders/aiohttp
that referenced
this pull request
Aug 22, 2015
Issues aio-libs#253 and aio-libs#254 implemented a `_conns` key evince logic in the function that actually **adds** items to `_conns` Issue aio-libs#406 tweaked this logic even more, making early and eviction of reusable items in the pool possible. Here we put the key eviction logic where it belongs: in the method that **removes** items from the `_conns` pool.
Merged
asvetlov
pushed a commit
that referenced
this pull request
Aug 28, 2015
Issues #253 and #254 implemented a `_conns` key evince logic in the function that actually **adds** items to `_conns` Issue #406 tweaked this logic even more, making early and eviction of reusable items in the pool possible. Here we put the key eviction logic where it belongs: in the method that **removes** items from the `_conns` pool.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon testing and touroughly reviewing tcpdump output, it appeared that the client keep-alive functionality was broken, creating a new socket for each request. This patch puts it back in place with minimal test edit.