Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor sendfile #3383

Merged
merged 18 commits into from
Nov 8, 2018
Merged

Refactor sendfile #3383

merged 18 commits into from
Nov 8, 2018

Conversation

asvetlov
Copy link
Member

@asvetlov asvetlov commented Nov 6, 2018

The main change is using add_done_callback to unregister writer early on future cancellation.

@codecov-io
Copy link

codecov-io commented Nov 6, 2018

Codecov Report

Merging #3383 into master will decrease coverage by 0.05%.
The diff coverage is 96.29%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3383      +/-   ##
=========================================
- Coverage   97.96%   97.9%   -0.06%     
=========================================
  Files          44      44              
  Lines        8489    8497       +8     
  Branches     1376    1375       -1     
=========================================
+ Hits         8316    8319       +3     
- Misses         74      77       +3     
- Partials       99     101       +2
Impacted Files Coverage Δ
aiohttp/web_fileresponse.py 94.67% <96.29%> (-2.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c96c9af...40097d7. Read the comment docs.

@asvetlov asvetlov mentioned this pull request Nov 7, 2018
5 tasks
@asvetlov asvetlov merged commit 690a3d4 into master Nov 8, 2018
@asvetlov asvetlov deleted the refactor-sendfile branch November 8, 2018 09:09
@lock
Copy link

lock bot commented Nov 8, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Nov 8, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Nov 8, 2019
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Nov 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bot:chronographer:provided There is a change note present in this PR outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants