Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test infra #3337

Merged
merged 3 commits into from
Oct 10, 2018
Merged

Fix test infra #3337

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b0a5de3
Remove duplicate loop
zhangyunhao116 Oct 10, 2018
fce473e
Fix typo
zhangyunhao116 Oct 10, 2018
b0c0f3f
Add changes
zhangyunhao116 Oct 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES/3337.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix tests/test_connector.py typo and tests/autobahn/server.py duplicate loop def.
2 changes: 0 additions & 2 deletions tests/autobahn/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,6 @@ async def finish(app, srv, handler):
loop = asyncio.get_event_loop()
logging.basicConfig(level=logging.DEBUG,
format='%(asctime)s %(levelname)s %(message)s')

loop = asyncio.get_event_loop()
app, srv, handler = loop.run_until_complete(main(loop))
try:
loop.run_forever()
Expand Down
2 changes: 1 addition & 1 deletion tests/test_connector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ def test_del_with_closed_loop(loop) -> None:
assert exc_handler.called


def test_del_empty_conector(loop) -> None:
def test_del_empty_connector(loop) -> None:
conn = aiohttp.BaseConnector(loop=loop)

exc_handler = mock.Mock()
Expand Down