Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis CI migration and packaging improvements #2990

Merged
merged 13 commits into from
May 17, 2018
Merged

Travis CI migration and packaging improvements #2990

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
ab017b3
Opt-in to use edge Travis CI config parser
webknjaz May 10, 2018
4dd1cb7
Drop outdated comment from Travis CI config
webknjaz May 10, 2018
a2f21b0
Turn env vars in Travis CI config to key-value
webknjaz May 10, 2018
dfa709c
Move towncrier linter into its own job
webknjaz May 10, 2018
d242c61
Upgrade refs across repo to point to travis-ci.com
webknjaz May 10, 2018
1fb2194
Make run_docker script saver to maintain
webknjaz May 10, 2018
b0223a0
Announce support for Python 3.7
webknjaz May 10, 2018
9f6f891
Use pytest-runner in dist setup
webknjaz May 10, 2018
8396818
Don't install mypy under PyPy
webknjaz May 10, 2018
b705aaa
Don't install uvloop under 3.7
webknjaz May 10, 2018
9396516
Run pytest directly in AppVeyor CI
webknjaz May 11, 2018
952c254
Polish job names
asvetlov May 15, 2018
a045cff
Use idiomatic python setup.py sdist
asvetlov May 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Use idiomatic python setup.py sdist
  • Loading branch information
@asvetlov
asvetlov committed May 17, 2018
commit a045cffe38e7a64690bcf326f35ad02aa4426c0c
2 changes: 1 addition & 1 deletion .appveyor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ test_script:
- "tools/build.cmd %PYTHON%\\python.exe -m pytest tests"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why -m? Technically setup.py is not an importable module but just a script.
Did I miss something?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running setup.py test is considered bad practice and it's broken in this CI for some reason. Thus we have to run pytest as it's designed to work.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I see


after_test:
- "tools/build.cmd %PYTHON%\\python.exe -m setup sdist bdist_wheel"
- "tools/build.cmd %PYTHON%\\python.exe setup.py sdist bdist_wheel"

artifacts:
- path: dist\*
Expand Down