Skip to content

Fix incrorect base class of ClientConnectorSSLError#2563

Merged
asvetlov merged 1 commit intoaio-libs:2.3from
roganov:fix-ClientConnectorSSLError-bases
Nov 27, 2017
Merged

Fix incrorect base class of ClientConnectorSSLError#2563
asvetlov merged 1 commit intoaio-libs:2.3from
roganov:fix-ClientConnectorSSLError-bases

Conversation

@roganov
Copy link
Copy Markdown
Contributor

@roganov roganov commented Nov 27, 2017

What do these changes do?

Changes base class of ClientConnectorSSLError from ClientConnectorError to ClientSSLError.

Are there changes in behavior for the user?

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bug)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@roganov roganov force-pushed the fix-ClientConnectorSSLError-bases branch from fe6be06 to 255e8a9 Compare November 27, 2017 14:37
@codecov-io
Copy link
Copy Markdown

codecov-io commented Nov 27, 2017

Codecov Report

Merging #2563 into 2.3 will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##              2.3    #2563   +/-   ##
=======================================
  Coverage   97.25%   97.25%           
=======================================
  Files          39       39           
  Lines        8238     8238           
  Branches     1442     1442           
=======================================
  Hits         8012     8012           
  Misses         98       98           
  Partials      128      128
Impacted Files Coverage Δ
aiohttp/client_exceptions.py 94.73% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fe3217...255e8a9. Read the comment docs.

@asvetlov asvetlov merged commit b7084cf into aio-libs:2.3 Nov 27, 2017
@asvetlov
Copy link
Copy Markdown
Member

Thanks!

@lock
Copy link
Copy Markdown

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bot:chronographer:provided There is a change note present in this PR outdated

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants