Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix test_multiple_drains (was not covering what it should) #2553

Merged
merged 1 commit into from
Nov 24, 2017

Conversation

arthurdarcet
Copy link
Contributor

@arthurdarcet arthurdarcet commented Nov 24, 2017

@asvetlov : sorry, should not have pushed my last PR #2126 so soon. I was still checking my test were covering everything, and the test_multiple_drains was not doing anything useful. This commit fixes it (and should improve the coverage a very tiny bit)

@codecov-io
Copy link

codecov-io commented Nov 24, 2017

Codecov Report

Merging #2553 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2553      +/-   ##
=========================================
+ Coverage   97.29%   97.3%   +0.01%     
=========================================
  Files          40      40              
  Lines        8134    8134              
  Branches     1432    1432              
=========================================
+ Hits         7914    7915       +1     
  Misses         89      89              
+ Partials      131     130       -1
Impacted Files Coverage Δ
aiohttp/http_writer.py 98.35% <0%> (+0.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbf6218...99bb53f. Read the comment docs.

@asvetlov
Copy link
Member

No problem.
Is the PR ready for merging?

@arthurdarcet
Copy link
Contributor Author

yes, all good

@asvetlov asvetlov merged commit a24af03 into aio-libs:master Nov 24, 2017
@asvetlov
Copy link
Member

Cool, thanks!

@arthurdarcet arthurdarcet deleted the fix-2126 branch November 24, 2017 11:09
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants