log a warning when sending requests with a large body of bytes #2127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthurdarcet
force-pushed
the
body-chunking
branch
from
5584964
to
6a7d22b
Compare
fafhrd91
reviewed
Jul 24, 2017
aiohttp/payload.py
Outdated
| @@ -150,6 +151,11 @@ def __init__(self, value, *args, **kwargs): | |||
|
|
|||
| self._size = len(value) | |||
|
|
|||
| if self._size > DEFAULT_LIMIT: | |||
There was a problem hiding this comment.
I think DEFAULT_LIMIT is too small. lets define new const, something close to 1mb
There was a problem hiding this comment.
ok, do you want it in payload.py or in stream.py next to the other constants?
arthurdarcet
force-pushed
the
body-chunking
branch
from
6a7d22b
to
be9ccd0
Compare
arthurdarcet
force-pushed
the
body-chunking
branch
from
be9ccd0
to
f0413c8
Compare
|
thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #2126 , log a warning when sending a request with a large body payload passed as bytes directly: aiohttp does not do any chunking for this use case, and it can freeze the event loop.