Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add wsgi support to GunicornWebWorker #1418

Merged
merged 2 commits into from
Nov 22, 2016
Merged

add wsgi support to GunicornWebWorker #1418

merged 2 commits into from
Nov 22, 2016

Conversation

fafhrd91
Copy link
Member

this is prerequisite for #1108, after aiohttp public release we can replace AiohttpWorker from gunicorn and then we can start wsgi deprecation process

@fafhrd91
Copy link
Member Author

@asvetlov

@AraHaan
Copy link
Contributor

AraHaan commented Nov 22, 2016

oh nice, would be nice if the checks on those 2 webhooks passed. :octocat:

@codecov-io
Copy link

codecov-io commented Nov 22, 2016

Current coverage is 98.88% (diff: 100%)

Merging #1418 into master will increase coverage by <.01%

@@             master      #1418   diff @@
==========================================
  Files            30         30          
  Lines          6900       6915    +15   
  Methods           0          0          
  Messages          0          0          
  Branches       1143       1147     +4   
==========================================
+ Hits           6823       6838    +15   
  Misses           33         33          
  Partials         44         44          

Powered by Codecov. Last update 987288f...6b331c3

@fafhrd91 fafhrd91 merged commit d4153c4 into master Nov 22, 2016
@fafhrd91 fafhrd91 deleted the wsgi-support branch November 22, 2016 16:51
@asvetlov
Copy link
Member

Looks good.
Would you create a functional wsgi test?
Frankly speaking I don't trust mock-only testing.

@fafhrd91
Copy link
Member Author

i don't really care about wsgi. i just want to start deprecation process.

@asvetlov
Copy link
Member

Ok

@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants