Skip to content

Conversation

@Dreamsorcerer
Copy link
Member

@Dreamsorcerer Dreamsorcerer commented Oct 25, 2025

I don't think these should have any actual impact, and the duplicate maintenance is prone to mistakes (note the extra unused type in the else block, top of web_app.py). A few similar cleanups here too.

@Dreamsorcerer Dreamsorcerer added backport:skip Skip backport bot bot:chronographer:skip This PR does not need to include a change note and removed backport:skip Skip backport bot labels Oct 25, 2025
@codecov
Copy link

codecov bot commented Oct 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.73%. Comparing base (6fabae5) to head (2d2b2ea).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11716      +/-   ##
==========================================
- Coverage   98.73%   98.73%   -0.01%     
==========================================
  Files         127      127              
  Lines       43558    43546      -12     
  Branches     2320     2320              
==========================================
- Hits        43007    42995      -12     
  Misses        390      390              
  Partials      161      161              
Flag Coverage Δ
CI-GHA 98.60% <100.00%> (-0.01%) ⬇️
OS-Linux 98.34% <100.00%> (-0.01%) ⬇️
OS-Windows 96.66% <97.87%> (-0.01%) ⬇️
OS-macOS 97.56% <100.00%> (-0.01%) ⬇️
Py-3.10.11 97.10% <100.00%> (-0.01%) ⬇️
Py-3.10.18 97.60% <100.00%> (-0.01%) ⬇️
Py-3.11.13 97.81% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 97.31% <100.00%> (-0.01%) ⬇️
Py-3.12.10 97.41% <100.00%> (-0.01%) ⬇️
Py-3.12.11 97.91% <100.00%> (-0.01%) ⬇️
Py-3.13.7 97.91% <100.00%> (-0.01%) ⬇️
Py-3.13.8 97.15% <100.00%> (+<0.01%) ⬆️
Py-3.13.9 96.24% <97.87%> (-0.01%) ⬇️
Py-3.14.0 98.11% <100.00%> (-0.01%) ⬇️
Py-3.14.0t 97.18% <100.00%> (-0.01%) ⬇️
Py-pypy3.10.16-7.3.19 94.21% <100.00%> (+2.09%) ⬆️
VM-macos 97.56% <100.00%> (-0.01%) ⬇️
VM-ubuntu 98.34% <100.00%> (-0.01%) ⬇️
VM-windows 96.66% <97.87%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 25, 2025

CodSpeed Performance Report

Merging #11716 will not alter performance

Comparing Dreamsorcerer-patch-5 (2d2b2ea) with master (6fabae5)

Summary

✅ 59 untouched

@Dreamsorcerer Dreamsorcerer changed the title Drop TYPE_CHECKING variables Cleanup TYPE_CHECKING variables Oct 25, 2025
@Dreamsorcerer Dreamsorcerer added the backport:skip Skip backport bot label Oct 25, 2025
@webknjaz
Copy link
Member

Sometimes, it may have impact. FWIW if we ever go for ruff some rules will force putting imports into type checking blocks. It may be worth trying to integrate it and make changes with more linters checking them.

@Dreamsorcerer
Copy link
Member Author

Sometimes, it may have impact. FWIW if we ever go for ruff some rules will force putting imports into type checking blocks. It may be worth trying to integrate it and make changes with more linters checking them.

I don't think there's any notable change to import behaviour here. Ruff is on the list of things to implement in future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip Skip backport bot bot:chronographer:skip This PR does not need to include a change note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants