-
-
Couldn't load subscription status.
- Fork 2.1k
Cleanup TYPE_CHECKING variables #11716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #11716 +/- ##
==========================================
- Coverage 98.73% 98.73% -0.01%
==========================================
Files 127 127
Lines 43558 43546 -12
Branches 2320 2320
==========================================
- Hits 43007 42995 -12
Misses 390 390
Partials 161 161
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #11716 will not alter performanceComparing Summary
|
|
Sometimes, it may have impact. FWIW if we ever go for ruff some rules will force putting imports into type checking blocks. It may be worth trying to integrate it and make changes with more linters checking them. |
I don't think there's any notable change to import behaviour here. Ruff is on the list of things to implement in future. |
I don't think these should have any actual impact, and the duplicate maintenance is prone to mistakes (note the extra unused type in the else block, top of web_app.py). A few similar cleanups here too.