BugFix in aiohttp.ClientSession that caused "Unclosed connector" warnings

CHANGES/2e6eba86.bugfix.rst

@@ -0,0 +1 @@
+Fixed an issue where ``aiohttp.ClientSession`` would raise an ``Unclosed connector`` warning for externally provided connectors -- by :user:`Ruke3663`.

CONTRIBUTORS.txt

@@ -318,6 +318,7 @@ Roman Markeloff
 Roman Podoliaka
 Roman Postnov
 Rong Zhang
+Ruke 3663
 Samir Akarioh
 Samuel Colvin
 Samuel Gaist

aiohttp/Dockerfile

@@ -0,0 +1,7 @@
+FROM public.ecr.aws/x8v8d7g8/mars-base:latest
+
+WORKDIR /app
+COPY . .
+
+RUN pip install -e .[test] pytest aiohttp
+CMD ["/bin/bash"]

aiohttp/client.py

@@ -318,7 +318,15 @@ def __init__(
             )
 
         if connector is None:
+            connector_owner = True
             connector = TCPConnector(ssl_shutdown_timeout=ssl_shutdown_timeout)
+        elif connector_owner:
+            warnings.warn(
+                "connector_owner is deprecated and will be removed in aiohttp 4.0.",
+                DeprecationWarning,
+                stacklevel=2,
+            )
+
         # Initialize these three attrs before raising any exception,
         # they are used in __del__
         self._connector = connector
@@ -333,14 +341,15 @@ def __init__(
         if connector._loop is not loop:
             raise RuntimeError("Session and connector have to use same event loop")
 
+        self._connector_owner = connector_owner
+
         if cookie_jar is None:
             cookie_jar = CookieJar()
         self._cookie_jar = cookie_jar
 
         if cookies:
             self._cookie_jar.update_cookies(cookies)
 
-        self._connector_owner = connector_owner
         self._default_auth = auth
         self._version = version
         self._json_serialize = json_serialize
@@ -1282,7 +1291,7 @@ def closed(self) -> bool:
 
         A readonly property.
         """
-        return self._connector is None or self._connector.closed
+        return self._connector is None
 
     @property
     def connector(self) -> BaseConnector | None: