Repository navigation
Do not assume Python 3.14 has stdlib zstd - #11611
Conversation
30f1d48 to
a9cc90c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #11611 +/- ##
==========================================
+ Coverage 98.19% 98.74% +0.55%
==========================================
Files 128 127 -1
Lines 43758 43450 -308
Branches 2386 2325 -61
==========================================
- Hits 42967 42905 -62
+ Misses 610 389 -221
+ Partials 181 156 -25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #11611 will not alter performanceComparing Summary
Footnotes |
Do not assume Python 3.14 has compression.zstd available, as that module depends on a shared library version that is not available on all platforms and distributions (e.g. Rocky Linux 8).
a9cc90c to
1cb6a09
Compare
for more information, see https://pre-commit.ci
Backport to 3.13: 💚 backport PR created✅ Backport PR branch: Backported as #11612 🤖 @patchback |
(cherry picked from commit 4929094)
Backport to 3.14: 💚 backport PR created✅ Backport PR branch: Backported as #11613 🤖 @patchback |
(cherry picked from commit 4929094)
Do not assume Python 3.14 has compression.zstd available, as that module depends on a shared library version that is not available on all platforms and distributions (e.g. Rocky Linux 8).
What do these changes do?
Prevents errors when using aiohttp from a Python 3.14 build that does not include
compression.zstdsupport.Are there changes in behavior for the user?
Fixes bug.
Is it a substantial burden for the maintainers to support this?
No
Related issue number
Fixes #11603
Checklist
CONTRIBUTORS.txtCHANGES/foldername it
<issue_or_pr_num>.<type>.rst(e.g.588.bugfix.rst)if you don't have an issue number, change it to the pull request
number after creating the PR
.bugfix: A bug fix for something the maintainers deemed animproper undesired behavior that got corrected to match
pre-agreed expectations.
.feature: A new behavior, public APIs. That sort of stuff..deprecation: A declaration of future API removals and breakingchanges in behavior.
.breaking: When something public is removed in a breaking way.Could be deprecated in an earlier release.
.doc: Notable updates to the documentation structure or buildprocess.
.packaging: Notes for downstreams about unobvious side effectsand tooling. Changes in the test invocation considerations and
runtime assumptions.
.contrib: Stuff that affects the contributor experience. e.g.Running tests, building the docs, setting up the development
environment.
.misc: Changes that are hard to assign to any of the abovecategories.
Make sure to use full sentences with correct case and punctuation,
for example:
Use the past tense or the present tense a non-imperative mood,
referring to what's changed compared to the last released version
of this project.