Skip to content

Conversation

@Dreamsorcerer
Copy link
Member

@Dreamsorcerer Dreamsorcerer commented May 19, 2025

No description provided.

@Dreamsorcerer Dreamsorcerer requested a review from asvetlov as a code owner May 19, 2025 22:34
@Dreamsorcerer Dreamsorcerer added the backport:skip Skip backport bot label May 19, 2025
@Dreamsorcerer
Copy link
Member Author

Dreamsorcerer commented May 19, 2025

@bdraco Does the proxy code have any impact on middlewares? Seems to be a ClientRequest created here with a lot less arguments, just wondering if there's any issue here:

proxy_req = ClientRequest(

Otherwise, I guess that's why all those parameters have defaults currently, in which case we'll need to do the same for these 2 as well.

@Dreamsorcerer Dreamsorcerer added this to the 4.0 milestone May 20, 2025
@codecov
Copy link

codecov bot commented May 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.73%. Comparing base (3115240) to head (a2cedb5).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10890   +/-   ##
=======================================
  Coverage   98.73%   98.73%           
=======================================
  Files         127      127           
  Lines       43558    43587   +29     
  Branches     2320     2320           
=======================================
+ Hits        43008    43037   +29     
  Misses        390      390           
  Partials      160      160           
Flag Coverage Δ
CI-GHA 98.61% <100.00%> (+<0.01%) ⬆️
OS-Linux 98.34% <100.00%> (+<0.01%) ⬆️
OS-Windows 96.67% <100.00%> (+<0.01%) ⬆️
OS-macOS 97.56% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 97.11% <100.00%> (+<0.01%) ⬆️
Py-3.10.18 97.61% <100.00%> (+<0.01%) ⬆️
Py-3.11.13 97.81% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 97.32% <100.00%> (+<0.01%) ⬆️
Py-3.12.10 97.42% <100.00%> (+<0.01%) ⬆️
Py-3.12.11 97.91% <100.00%> (-0.01%) ⬇️
Py-3.13.7 97.91% <100.00%> (+<0.01%) ⬆️
Py-3.13.8 97.15% <100.00%> (+<0.01%) ⬆️
Py-3.13.9 96.25% <100.00%> (+<0.01%) ⬆️
Py-3.14.0 98.12% <100.00%> (-0.01%) ⬇️
Py-3.14.0t 97.18% <100.00%> (-0.01%) ⬇️
Py-pypy3.10.16-7.3.19 88.33% <100.00%> (+5.54%) ⬆️
VM-macos 97.56% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 98.34% <100.00%> (+<0.01%) ⬆️
VM-windows 96.67% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dreamsorcerer
Copy link
Member Author

Otherwise, I guess that's why all those parameters have defaults currently, in which case we'll need to do the same for these 2 as well.

Feels to me like there should be a separate ClientProxyRequest or something. I think if we separated them, it'd remove a bunch of asserts and make static typing a lot cleaner.

@codspeed-hq
Copy link

codspeed-hq bot commented May 22, 2025

CodSpeed Performance Report

Merging #10890 will not alter performance

Comparing Dreamsorcerer-patch-4 (a2cedb5) with master (6fabae5)

Summary

✅ 59 untouched

bdraco added a commit that referenced this pull request May 23, 2025
This will avoid one breaking change in 4.0 in when
we make the other change in #10890

closes #10905
@bdraco bdraco self-requested a review October 24, 2025 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip Skip backport bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant