Explicitly return TimeoutError on WebSocketResponse.close() (#1084) #1089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 97.62% (diff: 100%)@@ master #1089 diff @@
==========================================
Files 28 28
Lines 6407 6432 +25
Methods 0 0
Messages 0 0
Branches 1078 1094 +16
==========================================
+ Hits 6260 6279 +19
- Misses 80 81 +1
- Partials 67 72 +5
|
| @@ -229,12 +230,14 @@ def handler(request): | |||
| assert 'request' == (yield from ws.receive_str()) | |||
| ws.send_str('reply') | |||
| begin = ws._loop.time() | |||
| yield from ws.close() | |||
| assert True == (yield from ws.close()) | |||
There was a problem hiding this comment.
Just assert (yield from ws.close()) would be fine.
|
I have fixed the branch according to your comments and rebased! |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Revises
WebSocketResponse.close()patch by explicitly returning TimeoutError with close code 1006 in #1084 for #1002.Are there changes in behavior for the user?
Nothing.
Related issue number
#1002
Checklist