Skip to content

Conversation

@bdraco
Copy link
Member

@bdraco bdraco commented Apr 18, 2025

Co-authored-by: Sam Bull git@sambull.org
(cherry picked from commit 8d74e26)

…10713)

Co-authored-by: Sam Bull <git@sambull.org>
(cherry picked from commit 8d74e26)
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Apr 18, 2025
@bdraco bdraco changed the title Avoid fetching loop time on each request unless logging is enabled (#10713) [PR #10713/8d74e26 backport][3.12] Avoid fetching loop time on each request unless logging is enabled Apr 18, 2025
@bdraco
Copy link
Member Author

bdraco commented Apr 18, 2025

since this backport was a bit tricky I also manually verified manually setting aiohttp.access level to DEBUG or INFO at run time results in logs
Apr 18 18:30:20 homeassistant homeassistant[618]: 2025-04-18 08:30:20.490 INFO (MainThread) [aiohttp.access] 192.168.107.66 [18/Apr/2025:08:30:20 -1000] "GET /api/nouser/lights HTTP/1.1" 200 654 "-" "LuaSocket 2.0.2"

@codspeed-hq
Copy link

codspeed-hq bot commented Apr 18, 2025

CodSpeed Performance Report

Merging #10739 will not alter performance

Comparing patchback/backports/3.12/8d74e26c70adeabda54c963d4744672c1874cb06/pr-10713 (9364ed0) with 3.12 (cc4b8c5)

Summary

✅ 56 untouched benchmarks

@bdraco bdraco marked this pull request as ready for review April 18, 2025 18:40
@bdraco bdraco enabled auto-merge (squash) April 18, 2025 18:40
@bdraco bdraco merged commit 47511fc into 3.12 Apr 18, 2025
35 checks passed
@bdraco bdraco deleted the patchback/backports/3.12/8d74e26c70adeabda54c963d4744672c1874cb06/pr-10713 branch April 18, 2025 18:43
@codecov
Copy link

codecov bot commented Jul 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (3.12@eacbe95). Learn more about missing BASE report.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.12   #10739   +/-   ##
=======================================
  Coverage        ?   98.11%           
=======================================
  Files           ?      126           
  Lines           ?    37923           
  Branches        ?     2138           
=======================================
  Hits            ?    37208           
  Misses          ?      546           
  Partials        ?      169           
Flag Coverage Δ
CI-GHA 98.00% <100.00%> (?)
OS-Linux 97.70% <100.00%> (?)
OS-Windows 94.81% <100.00%> (?)
OS-macOS 96.84% <100.00%> (?)
Py-3.10.11 96.74% <100.00%> (?)
Py-3.10.17 97.29% <100.00%> (?)
Py-3.11.12 96.74% <100.00%> (?)
Py-3.11.9 94.48% <100.00%> (?)
Py-3.12.10 96.83% <100.00%> (?)
Py-3.12.9 96.93% <100.00%> (?)
Py-3.13.2 96.92% <100.00%> (?)
Py-3.13.3 97.49% <100.00%> (?)
Py-3.9.13 96.62% <100.00%> (?)
Py-3.9.22 96.98% <100.00%> (?)
Py-pypy7.3.16 83.51% <20.00%> (?)
VM-macos 96.84% <100.00%> (?)
VM-ubuntu 97.70% <100.00%> (?)
VM-windows 94.81% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:chronographer:provided There is a change note present in this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants