Skip to content

Conversation

@bdraco
Copy link
Member

@bdraco bdraco commented Apr 18, 2025

Co-authored-by: Sam Bull git@sambull.org
(cherry picked from commit 8d74e26)

…10713)

Co-authored-by: Sam Bull <git@sambull.org>
(cherry picked from commit 8d74e26)
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Apr 18, 2025
@bdraco bdraco changed the title Avoid fetching loop time on each request unless logging is enabled (#10713) [PR #10713/8d74e26 backport][3.11] Avoid fetching loop time on each request unless logging is enabled Apr 18, 2025
@codecov
Copy link

codecov bot commented Apr 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.10%. Comparing base (eadcd28) to head (d4adad5).
Report is 34 commits behind head on 3.11.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.11   #10738   +/-   ##
=======================================
  Coverage   98.09%   98.10%           
=======================================
  Files         126      126           
  Lines       37572    37591   +19     
  Branches     4539     4538    -1     
=======================================
+ Hits        36858    36879   +21     
+ Misses        538      537    -1     
+ Partials      176      175    -1     
Flag Coverage Δ
CI-GHA 97.99% <100.00%> (+<0.01%) ⬆️
OS-Linux 97.69% <100.00%> (+<0.01%) ⬆️
OS-Windows 94.75% <100.00%> (-0.01%) ⬇️
OS-macOS 96.82% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 96.68% <100.00%> (+<0.01%) ⬆️
Py-3.10.17 97.21% <100.00%> (-0.04%) ⬇️
Py-3.11.12 97.28% <100.00%> (+0.01%) ⬆️
Py-3.11.9 96.76% <100.00%> (+<0.01%) ⬆️
Py-3.12.10 97.46% <100.00%> (+<0.01%) ⬆️
Py-3.12.9 96.88% <100.00%> (+<0.01%) ⬆️
Py-3.13.2 96.87% <100.00%> (-0.01%) ⬇️
Py-3.13.3 97.46% <100.00%> (+0.05%) ⬆️
Py-3.9.13 96.58% <100.00%> (+<0.01%) ⬆️
Py-3.9.22 97.11% <100.00%> (-0.04%) ⬇️
Py-pypy7.3.16 96.72% <100.00%> (+0.01%) ⬆️
VM-macos 96.82% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 97.69% <100.00%> (+<0.01%) ⬆️
VM-windows 94.75% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq
Copy link

codspeed-hq bot commented Apr 18, 2025

CodSpeed Performance Report

Merging #10738 will not alter performance

Comparing patchback/backports/3.11/8d74e26c70adeabda54c963d4744672c1874cb06/pr-10713 (d4adad5) with 3.11 (eadcd28)

Summary

✅ 52 untouched benchmarks

@bdraco
Copy link
Member Author

bdraco commented Apr 18, 2025

since this backport was a bit tricky I also manually verified manually setting aiohttp.access level to DEBUG or INFO at run time results in logs
Apr 18 18:30:20 homeassistant homeassistant[618]: 2025-04-18 08:30:20.490 INFO (MainThread) [aiohttp.access] 192.168.107.66 [18/Apr/2025:08:30:20 -1000] "GET /api/nouser/lights HTTP/1.1" 200 654 "-" "LuaSocket 2.0.2"

@bdraco bdraco marked this pull request as ready for review April 18, 2025 18:39
@bdraco bdraco merged commit 2c3b885 into 3.11 Apr 18, 2025
36 checks passed
@bdraco bdraco deleted the patchback/backports/3.11/8d74e26c70adeabda54c963d4744672c1874cb06/pr-10713 branch April 18, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:chronographer:provided There is a change note present in this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants