Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebSocket internal implementation refactoring #1021

Merged
merged 11 commits into from
Jul 31, 2016
Merged

WebSocket internal implementation refactoring #1021

merged 11 commits into from
Jul 31, 2016

Conversation

asvetlov
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Jul 30, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-0.003%) to 97.925% when pulling d9f26d6 on ws into 1a61823 on master.

kxepal
kxepal reviewed Jul 30, 2016
View reviewed changes
aiohttp/_ws_impl.py
ping = 0x9
pong = 0xa
close = 0x8
closed = 20
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While else numbers are hex-like, why these are not?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.
Because technically they are not constants defined by RFC but user values.
I'll start them from 0x100 to never clash with future websocket standard updates.

@coveralls
Copy link

coveralls commented Jul 30, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-0.003%) to 97.925% when pulling 5879343 on ws into 5853e7b on master.

@coveralls
Copy link

coveralls commented Jul 31, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-0.003%) to 97.925% when pulling 0b2f61d on ws into 5853e7b on master.

@coveralls
Copy link

coveralls commented Jul 31, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.03%) to 97.956% when pulling c2d22bf on ws into 5853e7b on master.

@coveralls
Copy link

coveralls commented Jul 31, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-0.002%) to 97.926% when pulling a78333f on ws into 5853e7b on master.

@asvetlov asvetlov merged commit b0ecd21 into master Jul 31, 2016
@asvetlov asvetlov deleted the ws branch July 31, 2016 14:54
@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
outdated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asvetlov @coveralls @kxepal