Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #10003/78d1be5 backport][3.10] Fix client connection header not reflecting connector force_close value #10008

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 20, 2024

(cherry picked from commit 78d1be5)

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Nov 20, 2024
@bdraco bdraco changed the title Fix client connection header not reflecting connector force_close value (#10003) [PR #10003/78d1be5 backport][3.10] Fix client connection header not reflecting connector force_close value Nov 20, 2024
@bdraco bdraco marked this pull request as ready for review November 20, 2024 21:34
Copy link

codspeed-hq bot commented Nov 20, 2024

CodSpeed Performance Report

Merging #10008 will not alter performance

Comparing patchback/backports/3.10/78d1be5d79f67597313354646eec200ff603fd9d/pr-10003 (90a8951) with 3.10 (f5d5da4)

Summary

✅ 43 untouched benchmarks

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.94%. Comparing base (361db7c) to head (90a8951).
Report is 133 commits behind head on 3.10.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             3.10   #10008      +/-   ##
==========================================
+ Coverage   97.78%   97.94%   +0.15%     
==========================================
  Files         108      116       +8     
  Lines       34840    36217    +1377     
  Branches     4164     4385     +221     
==========================================
+ Hits        34070    35473    +1403     
+ Misses        573      552      -21     
+ Partials      197      192       -5     
Flag Coverage Δ
CI-GHA 97.84% <100.00%> (+0.15%) ⬆️
OS-Linux 97.53% <100.00%> (+0.16%) ⬆️
OS-Windows 95.17% <100.00%> (+0.20%) ⬆️
OS-macOS 97.24% <100.00%> (+0.18%) ⬆️
Py-3.10.11 97.10% <100.00%> (+0.05%) ⬆️
Py-3.10.15 97.04% <100.00%> (+0.06%) ⬆️
Py-3.11.10 97.11% <100.00%> (+0.16%) ⬆️
Py-3.11.9 97.18% <100.00%> (+0.14%) ⬆️
Py-3.12.6 ?
Py-3.12.7 97.61% <100.00%> (?)
Py-3.13.0 97.60% <100.00%> (?)
Py-3.8.10 94.57% <100.00%> (+0.08%) ⬆️
Py-3.8.18 96.89% <100.00%> (+0.11%) ⬆️
Py-3.9.13 97.01% <100.00%> (+0.06%) ⬆️
Py-3.9.20 96.96% <100.00%> (+0.06%) ⬆️
Py-pypy7.3.16 96.56% <100.00%> (+0.06%) ⬆️
VM-macos 97.24% <100.00%> (+0.18%) ⬆️
VM-ubuntu 97.53% <100.00%> (+0.16%) ⬆️
VM-windows 95.17% <100.00%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit b069515 into 3.10 Nov 20, 2024
39 of 40 checks passed
@bdraco bdraco deleted the patchback/backports/3.10/78d1be5d79f67597313354646eec200ff603fd9d/pr-10003 branch November 20, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant