Mypy coverage (#5457)

Co-authored-by: Sam Bull <git@sambull.org>

.mypy.ini

@@ -1,24 +1,45 @@
 [mypy]
-warn_unused_configs = True
-strict = True
+files = aiohttp, examples, tests
+check_untyped_defs = True
+follow_imports_for_stubs = True
+#disallow_any_decorated = True
+disallow_any_generics = True
+disallow_incomplete_defs = True
+disallow_subclassing_any = True
+disallow_untyped_calls = True
+disallow_untyped_decorators = True
+disallow_untyped_defs = True
+implicit_reexport = False
+no_implicit_optional = True
+show_error_codes = True
+strict_equality = True
+warn_incomplete_stub = True
+warn_redundant_casts = True
+#warn_unreachable = True
+warn_unused_ignores = True
+disallow_any_unimported = True
+warn_return_any = True
+
+[mypy-tests.*]
+disallow_untyped_defs = False
 
 [mypy-aiodns]
 ignore_missing_imports = True
 
-[mypy-brotli]
+[mypy-asynctest]
 ignore_missing_imports = True
 
-[mypy-gunicorn.*]
+[mypy-brotli]
 ignore_missing_imports = True
 
-[mypy-uvloop]
+[mypy-cchardet]
 ignore_missing_imports = True
 
-[mypy-cchardet]
+[mypy-gunicorn.*]
 ignore_missing_imports = True
 
 [mypy-tokio]
 ignore_missing_imports = True
 
-[mypy-asynctest]
+[mypy-uvloop]
 ignore_missing_imports = True

CHANGES/5457.misc

@@ -0,0 +1 @@
+Improve Mypy coverage.

Makefile

@@ -74,7 +74,7 @@ fmt format:
 
 .PHONY: mypy
 mypy:
-	mypy --show-error-codes aiohttp tests
+	mypy
 
 .develop: .install-deps $(call to-hash,$(PYS) $(CYS) $(CS))
 	pip install -e .

aiohttp/resolver.py

@@ -1,6 +1,6 @@
 import asyncio
 import socket
-from typing import Any, Dict, List
+from typing import Any, Dict, List, Type, Union
 
 from .abc import AbstractResolver
 
@@ -104,4 +104,5 @@ async def close(self) -> None:
         self._resolver.cancel()
 
 
-DefaultResolver = AsyncResolver if aiodns_default else ThreadedResolver
+_DefaultType = Type[Union[AsyncResolver, ThreadedResolver]]
+DefaultResolver: _DefaultType = AsyncResolver if aiodns_default else ThreadedResolver

aiohttp/worker.py

@@ -29,7 +29,7 @@
 __all__ = ("GunicornWebWorker", "GunicornUVLoopWebWorker", "GunicornTokioWebWorker")
 
 
-class GunicornWebWorker(base.Worker):  # type: ignore[misc]
+class GunicornWebWorker(base.Worker):  # type: ignore[misc,no-any-unimported]
 
     DEFAULT_AIOHTTP_LOG_FORMAT = AccessLogger.LOG_FORMAT
     DEFAULT_GUNICORN_LOG_FORMAT = GunicornAccessLogFormat.default

examples/background_tasks.py

@@ -45,7 +45,7 @@ async def listen_to_redis(app: web.Application) -> None:
 
 
 async def start_background_tasks(app: web.Application) -> None:
-    app["redis_listener"] = app.loop.create_task(listen_to_redis(app))
+    app["redis_listener"] = asyncio.create_task(listen_to_redis(app))
 
 
 async def cleanup_background_tasks(app: web.Application) -> None:

examples/client_json.py

@@ -4,7 +4,7 @@
 import aiohttp
 
 
-async def fetch(session: aiohttp.ClientSession):
+async def fetch(session: aiohttp.ClientSession) -> None:
     print("Query http://httpbin.org/get")
     async with session.get("http://httpbin.org/get") as resp:
         print(resp.status)

examples/fake_server.py

@@ -6,9 +6,10 @@
 from typing import Any, Dict, List, Union
 
 from aiohttp import ClientSession, TCPConnector, resolver, test_utils, web
+from aiohttp.abc import AbstractResolver
 
 
-class FakeResolver:
+class FakeResolver(AbstractResolver):
     _LOCAL_HOST = {0: "127.0.0.1", socket.AF_INET: "127.0.0.1", socket.AF_INET6: "::1"}
 
     def __init__(self, fakes: Dict[str, int]) -> None:
@@ -50,7 +51,7 @@ def __init__(self) -> None:
                 web.get("/v2.7/me/friends", self.on_my_friends),
             ]
         )
-        self.runner = None
+        self.runner = web.AppRunner(self.app)
         here = pathlib.Path(__file__)
         ssl_cert = here.parent / "server.crt"
         ssl_key = here.parent / "server.key"

examples/web_cookies.py

@@ -3,6 +3,7 @@
 """
 
 from pprint import pformat
+from typing import NoReturn
 
 from aiohttp import web
 
@@ -22,13 +23,13 @@ async def root(request: web.Request) -> web.StreamResponse:
     return resp
 
 
-async def login(request: web.Request) -> None:
+async def login(request: web.Request) -> NoReturn:
     exc = web.HTTPFound(location="/")
     exc.set_cookie("AUTH", "secret")
     raise exc
 
 
-async def logout(request: web.Request) -> None:
+async def logout(request: web.Request) -> NoReturn:
     exc = web.HTTPFound(location="/")
     exc.del_cookie("AUTH")
     raise exc