-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement CorsViewMixin #145
Conversation
Great contribution! |
Codecov Report
@@ Coverage Diff @@
## master #145 +/- ##
=========================================
+ Coverage 80.95% 84.5% +3.55%
=========================================
Files 7 9 +2
Lines 357 413 +56
Branches 65 72 +7
=========================================
+ Hits 289 349 +60
+ Misses 44 42 -2
+ Partials 24 22 -2
Continue to review full report at Codecov.
|
@pedrokiefer please take a look on https://codecov.io/gh/aio-libs/aiohttp-cors/pull/145/diff |
P.S. I like the PR in general, usage snippet looks pretty elegant. |
@asvetlov thanks, i'll work on those issues tomorrow. |
I see many duplications (copy-pastes from |
My first try was reusing Do you have any objection on extracting |
Love the idea. Especially love underscore prefix for proposed names :) |
Done! :) |
Cool! |
Thanks! |
Fix #41!