Fix parsing for sync gateway #11
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like a linter issue. Could you fix it? Thanks for aiojson link, I'll check it soon. |
added 2 commits
February 8, 2016 09:36
|
Okay, I fixed the linter issue. Last days have been too busy... |
|
I let myself to squash commits for you. Thanks! P.S. Yea, busy days here too /: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new code works well in line per line, and probably for couchdb 2.0. However, couchbase sync gateway has another peculiarity, in that the "total_rows": X, "offset": Y fields come AFTER the rows, with slightly different sequence of closing brackets :(
I made a small adjustment to the parsing code, so it can handle both variants. And tested on sync gateway and couchdb 1.4.
Still working on a more general solution at https://github.com/ethanfrey/aiojson ...