-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize build configuration #1160
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1160 +/- ##
==========================================
- Coverage 87.03% 86.98% -0.05%
==========================================
Files 64 64
Lines 5969 5978 +9
==========================================
+ Hits 5195 5200 +5
- Misses 774 778 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I think setuptools is going away no? I remember now using the |
Not really: I am working on modernizing our build and packaging setup, which will include switching the build tool to |
7ee4b77
to
0570408
Compare
d9f2725
to
bd8e300
Compare
bd8e300
to
34f8dcc
Compare
34f8dcc
to
0d06dd2
Compare
Thank you for reviewing, @thehesiod & @webknjaz! |
Description of Change
MANIFEST.in
-> gets rid of build warningsinclude_package_data
andpackages
tosetup()
-> gets rid of build issues aroundretries
sub-package[build-system]
table topyproject.toml
[project]
table topyproject.toml
and merge contents ofsetup.py
into itAssumptions
setuptools
is kept as build backend (for now)python -m build
and confirmed that they are equivalent.Checklist for All Submissions
Checklist when updating botocore and/or aiohttp versions