Skip to content

Commit

Permalink
Lint on Go 1.9, drop 1.7 (uber-go#524)
Browse files Browse the repository at this point in the history
We're already building on Go 1.9; now that it's been out for a bit,
start running the linters there too. Since we're only committed to
supporting the last two releases, drop 1.7 to speed up Travis runs.

Fixes uber-go#509.
  • Loading branch information
akshayjshah authored Oct 31, 2017
1 parent 748a72a commit e003780
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
2 changes: 0 additions & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,13 +1,11 @@
language: go
sudo: false
go:
- 1.7
- 1.8
- 1.9
go_import_path: go.uber.org/zap
env:
global:
- GO15VENDOREXPERIMENT=1
- TEST_TIMEOUT_SCALE=10
cache:
directories:
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ PKG_FILES ?= *.go zapcore benchmarks buffer zapgrpc zaptest zaptest/observer int
# stable release.
GO_VERSION := $(shell go version | cut -d " " -f 3)
GO_MINOR_VERSION := $(word 2,$(subst ., ,$(GO_VERSION)))
LINTABLE_MINOR_VERSIONS := 8
LINTABLE_MINOR_VERSIONS := 9
ifneq ($(filter $(LINTABLE_MINOR_VERSIONS),$(GO_MINOR_VERSION)),)
SHOULD_LINT := true
endif
Expand Down

0 comments on commit e003780

Please sign in to comment.