Skip to content

Make evaluation name optional #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Make evaluation name optional #66

wants to merge 4 commits into from

Conversation

ramoncelestino
Copy link
Collaborator

No description provided.

@ramoncelestino ramoncelestino requested a review from pjoshi30 June 27, 2025 15:06
@@ -144,8 +144,8 @@ def evaluate(
application_name,
model_name,
dataset_collection_name,
evaluation_name,
headers,
headers,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets keep the order the same for backward compatibility

Copy link
Contributor

@pjoshi30 pjoshi30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM since tests passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants